Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement size limit for the cache of opened IPC handles#998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bratpiorka merged 6 commits intooneapi-src:mainfromvinser52:svinogra_ipc_cache
Mar 11, 2025

Conversation

@vinser52
Copy link
Contributor

@vinser52vinser52 commentedDec 17, 2024•
edited
Loading

Description

It is a follow-up of the#736. Add an environment variable that allows setting a limit for the size of the cache of opened IPC handles.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • New tests added, especially if they will fail without my changes
  • Extended the README/documentation

@vinser52
Copy link
ContributorAuthor

TODO: need to add tests

@lukaszstolarczuk
Copy link
Contributor

and probably you could add some info about this var into README, pls

vinser52 reacted with thumbs up emoji

@vinser52
Copy link
ContributorAuthor

and probably you could add some info about this var into README, pls

Sure, I will do that.

@bratpiorka
Copy link
Contributor

@vinser52 what are the plans for this PR? Is it working and ready to review?

@vinser52
Copy link
ContributorAuthor

@vinser52 what are the plans for this PR? Is it working and ready to review?

It is not ready yet. I am working on it right now. Need to implement proper refcounting and eviction.

@vinser52vinser52force-pushed thesvinogra_ipc_cache branch 4 times, most recently from00e4b48 tof6b00ecCompareFebruary 21, 2025 11:31
@vinser52vinser52 marked this pull request as ready for reviewFebruary 21, 2025 11:32
@vinser52vinser52 requested a review froma team as acode ownerFebruary 21, 2025 11:32
@vinser52
Copy link
ContributorAuthor

and probably you could add some info about this var into README, pls

@lukaszstolarczuk Done. I updated the online documentation.

@vinser52vinser52force-pushed thesvinogra_ipc_cache branch 2 times, most recently fromabe2ff4 toaa8c457CompareFebruary 22, 2025 21:28
@vinser52vinser52force-pushed thesvinogra_ipc_cache branch 3 times, most recently from4f58542 to11c7f6dCompareMarch 5, 2025 19:47
ldorau

This comment was marked as outdated.

Copy link
Contributor

@ldorauldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM except the above question

@ldorau
Copy link
Contributor

@bratpiorka@lplewa@igchor please re-review

@ldorau
Copy link
Contributor

@vinser52 please rebase

vinser52 reacted with thumbs up emoji

@vinser52
Copy link
ContributorAuthor

@vinser52 please rebase

Done

@bratpiorkabratpiorka merged commit785c710 intooneapi-src:mainMar 11, 2025
81 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ldorauldorauldorau approved these changes

@KFilipekKFilipekKFilipek approved these changes

@bratpiorkabratpiorkabratpiorka approved these changes

@lplewalplewaAwaiting requested review from lplewa

+1 more reviewer

@igchorigchorigchor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.x

Development

Successfully merging this pull request may close these issues.

6 participants

@vinser52@lukaszstolarczuk@bratpiorka@ldorau@KFilipek@igchor
[8]ページ先頭
©2009-2025 Movatter.jp