- Notifications
You must be signed in to change notification settings - Fork11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fs: move ml.Config to fs package#9873
base:main
Are you sure you want to change the base?
Conversation
| @@ -39,7 +40,7 @@ func devices() []*C.struct_ggml_backend_device { | |||
| } | |||
| type Backend struct { | |||
| meta *fs.GGML | |||
| meta *fsggml.GGML | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we want to tie the model format to the backend like this? Ideally backends can transparently load fromggml or other formats later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ideally yes but that can be an improvement later when there are more file formats and backends
move the
Configinterface frommltofssince it is more representative of the on-disk metadata than the runtime model