Commita771e10

committed

refactor(repo): parameter renaming and cleanup

* renamed `consider_submodules` to `submodules` to be in line with the existing parameters. Nowadays I would prefer the `consider_` prefix, but can't change the existing API and thus stick to the current naming scheme.* reduced amount of code in one portion to make it more maintainable.Related togitpython-developers#294

1 parentb8e700e commita771e10Copy full SHA for a771e10

File tree

1 file changed

-6

lines changed

git/repo
- base.py

1 file changed

-6

lines changed

`‎git/repo/base.py`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ def _set_alternates(self, alts):`
`564`	`564`	`doc="Retrieve a list of alternates paths or set a list paths to be used as alternates")`
`565`	`565`
`566`	`566`	`defis_dirty(self,index=True,working_tree=True,untracked_files=False,`
`567`		`-consider_submodules=True):`
	`567`	`+submodules=True):`
`568`	`568`	`"""`
`569`	`569`	`:return:`
`570`	`570`	``True``, the repository is considered dirty. By default it will react
`@@ -577,7 +577,7 @@ def is_dirty(self, index=True, working_tree=True, untracked_files=False,`
`577`	`577`
`578`	`578`	`# start from the one which is fastest to evaluate`
`579`	`579`	`default_args= ['--abbrev=40','--full-index','--raw']`
`580`		`-ifnotconsider_submodules:`
	`580`	`+ifnotsubmodules:`
`581`	`581`	`default_args.append('--ignore-submodules')`
`582`	`582`	`ifindex:`
`583`	`583`	`# diff index against HEAD`
`@@ -591,10 +591,7 @@ def is_dirty(self, index=True, working_tree=True, untracked_files=False,`
`591`	`591`	`returnTrue`
`592`	`592`	`# END working tree handling`
`593`	`593`	`ifuntracked_files:`
`594`		`-kwargs= {}`
`595`		`-ifnotconsider_submodules:`
`596`		`-kwargs['ignore_submodules']=True`
`597`		`-iflen(self._get_untracked_files(**kwargs)):`
	`594`	`+iflen(self._get_untracked_files(ignore_submodules=notsubmodules)):`
`598`	`595`	`returnTrue`
`599`	`596`	`# END untracked files`
`600`	`597`	`returnFalse`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita771e10

File tree

1 file changed

1 file changed

`‎git/repo/base.py`

0 commit comments