Commit982eefb

committed

fix(test_git): handleselect.poll() missing

In that case, the handler for processing stdout and stderr of the gitprocess is offloaded to threads. These currently don't returnany exception they raise.We could easily fix this using an approach as shown[here](http://goo.gl/hnVax6).

1 parent152a60f commit982eefbCopy full SHA for 982eefb

File tree

1 file changed

+10

-6

lines changed

git/test
- test_git.py

1 file changed

+10

-6

lines changed

`‎git/test/test_git.py`

Lines changed: 10 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,10 +192,14 @@ def test_environment(self, rw_dir):`
`192`	`192`	`rw_repo=Repo.init(os.path.join(rw_dir,'repo'))`
`193`	`193`	`remote=rw_repo.create_remote('ssh-origin',"ssh://git@server/foo")`
`194`	`194`
`195`		`-withrw_repo.git.custom_environment(GIT_SSH=path):`
`196`		`-try:`
`197`		`-remote.fetch()`
`198`		`-exceptGitCommandErroraserr:`
`199`		`-assert'FOO'instr(err)`
	`195`	`+# This only works if we are not evaluating git-push/pull output in a thread !`
	`196`	`+importselect`
	`197`	`+ifhasattr(select,'poll'):`
	`198`	`+withrw_repo.git.custom_environment(GIT_SSH=path):`
	`199`	`+try:`
	`200`	`+remote.fetch()`
	`201`	`+exceptGitCommandErroraserr:`
	`202`	`+assert'FOO'instr(err)`
	`203`	`+# end`
`200`	`204`	`# end`
`201`		`-# end`
	`205`	`+# end if select.poll exists`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit982eefb

File tree

1 file changed

1 file changed

`‎git/test/test_git.py`

0 commit comments