oceanbase/oceanbasePublic

NotificationsYou must be signed in to change notification settings
Fork1.9k
Star10k

caching/maxResultSize/batch/allowPartialResults & checkExists/existsAll optimize#2106

Open

HexyinUESTC wants to merge 5 commits intooceanbase:masterfrom

HexyinUESTC:master

Open

caching/maxResultSize/batch/allowPartialResults & checkExists/existsAll optimize#2106
HexyinUESTC wants to merge 5 commits intooceanbase:masterfrom
HexyinUESTC:master

Conversation

Copy link

HexyinUESTC commentedAug 28, 2024•
edited
Loading

Task Description

To be compatible with HBase 1.x

Solution Description

add limit caching/maxResultSize/batch/allowPartialResults and optimize checkExists/existsAll

Passed Regressions

Upgrade Compatibility

Other Information

Release Note

HexyinUESTCand others added3 commits

August 23, 2024 11:32

add ObParams

8fc2f70

add params

30de3af

Merge branch 'oceanbase:master' into master

7cbec9c

HexyinUESTC force-pushed themaster branch 2 times, most recently from019836d tod64ffb6Compare

August 29, 2024 06:20

Copy link

Contributor

shenyunlong commentedAug 29, 2024

The PR's title should in English.

shenyunlong reviewed

Aug 29, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp OutdatedShow resolvedHide resolved

src/share/table/ob_table.h OutdatedShow resolvedHide resolved

src/share/table/ob_table.cpp OutdatedShow resolvedHide resolved

HexyinUESTC changed the title~~caching/maxResultSize/batch/allowPartialResults & checkExists/existsAll 优化~~caching/maxResultSize/batch/allowPartialResults & checkExists/existsAll optimize

Aug 29, 2024

shenyunlong reviewed

Aug 29, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cppShow resolvedHide resolved

src/observer/table/ob_htable_filter_operator.cpp OutdatedShow resolvedHide resolved

src/share/table/ob_table.h OutdatedShow resolvedHide resolved

src/share/table/ob_table.cpp OutdatedShow resolvedHide resolved

src/observer/table/ob_htable_filter_operator.hShow resolvedHide resolved

src/share/table/ob_table.cppShow resolvedHide resolved

src/share/table/ob_table.cpp OutdatedShow resolvedHide resolved

HexyinUESTC force-pushed themaster branch 2 times, most recently from831a194 to281cd8eCompare

August 30, 2024 07:42

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cppShow resolvedHide resolved

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated

		init_properties(hbase_params, query);
		}

		bool ObHTableFilterOperator::reach_caching_limit(int num_of_row) {

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

reach_caching_limit(int num_of_row) {
->
reach_caching_limit(int num_of_row)
{

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated

		ObArray<ObObj> fake_row;
		one_result_->reset();
		if (OB_FAIL(one_result_->add_row(fake_row))) {
		ret = OB_ERR_ADD_INDEX;

Copy link

Contributor

shenyunlongAug 30, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

retcode will be overwrite here

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated

		return ret;
		}

		void ObHTableFilterOperator::check_exist_only() {

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this function seems useless

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated


		ScannerContext::ScannerContext()
		{
		limits_.set_fields(limit_default_value_, limit_default_value_, limit_default_value_, LimitScope::Scope::BETWEEN_ROWS);

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe it's better to use static const for default value

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated

		bool ScannerContext::check_batch_limit(LimitScope checker_scope)
		{
		if (limits_.can_enforce_batch_from_scope(checker_scope) && limits_.get_batch() > 0) {
		return progress_.get_batch() >= limits_.get_batch();

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

only one return is allowed

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated


		bool ScannerContext::check_size_limit(LimitScope checker_scope) {
		if (limits_.can_enforce_size_from_scope(checker_scope) && limits_.get_size() >0 ) {
		return progress_.get_size() >= limits_.get_size();

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

only one return is allowed

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.cpp Outdated

		bool ScannerContext::check_time_limit(LimitScope checker_scope)
		{
		if (limits_.can_enforce_time_from_scope(checker_scope) && limits_.get_time() > 0) {
		return progress_.get_time() >= limits_.get_time();

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

only one return is allowed

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.h Outdated

		};


		class LimitScope {

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LimitScope {
->
LimitScope
{

shenyunlong reviewed

Aug 30, 2024

View reviewed changes

src/observer/table/ob_htable_filter_operator.h Outdated


		class LimitScope {
		public:
		enum class Scope {

Copy link

Contributor

shenyunlongAug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Scope {
->
Scope
{

HexyinUESTC force-pushed themaster branch from281cd8e to00a1d56Compare

August 30, 2024 09:54

HBase compatible

01175a9

HexyinUESTC force-pushed themaster branch from00a1d56 to01175a9Compare

August 30, 2024 10:16

optimize grammar

8a3476b

Labels

None yet

Movatterモバイル変換

Conversation

HexyinUESTC commentedAug 28, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Task Description

Solution Description

Passed Regressions

Upgrade Compatibility

Other Information

Release Note

Uh oh!

shenyunlong commentedAug 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shenyunlongAug 30, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

HexyinUESTC commentedAug 28, 2024•
edited
Loading

shenyunlongAug 30, 2024•
edited
Loading