Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
/dunePublic
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

chore: add x-maintenance-intent to dune opam files#11275

Open
art-w wants to merge2 commits intoocaml:main
base:main
Choose a base branch
Loading
fromart-w:maintenance-intent-latest

Conversation

art-w
Copy link
Contributor

Using#11274 to add it to every opam files. My understanding is that only the"(latest)" version is the one actively maintained, but it's easy to change if you want to include more versions.

@art-wart-w marked this pull request as draftJanuary 7, 2025 14:11
@Leonidas-from-XIV
Copy link
Collaborator

The OPAM files are generated automatically fromdune-project so unless the change is added in the respective.template files, the change will be removed on the nextdune build. I suggest landing#11274 first and then addingmaintenance_intent to ourdune-project in this PR, which will automatically update the opam files.

art-w reacted with thumbs up emoji

@art-wart-wforce-pushed themaintenance-intent-latest branch from98c9a89 toc1a0148CompareJanuary 15, 2025 15:01
@maistemaisteforce-pushed themaintenance-intent-latest branch fromc1a0148 toc1c53bcCompareJanuary 21, 2025 13:15
Copy link
Collaborator

@Leonidas-from-XIVLeonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think some of these changes need to be discussed because while we do release them as packages I don't think all of them are meant to be used by others.

e.g. I don't think that we would do a patch-release for a bug instdune if it doesn't affect thedune package. We'd probably fix it upstream to prevent it becoming an issue in the future but a lot of these packages are really just to support Dune.

@maistemaisteforce-pushed themaintenance-intent-latest branch 2 times, most recently from002b084 to4a5b03bCompareJanuary 23, 2025 14:04
@Leonidas-from-XIV
Copy link
Collaborator

@rgrinberg Can you take a look and confirm that this matches our maintenance policy?

@maistemaisteforce-pushed themaintenance-intent-latest branch from4a5b03b to4b63540CompareJanuary 23, 2025 14:05
@maistemaiste marked this pull request as ready for reviewJanuary 23, 2025 14:05
@maistemaiste changed the titleAdd x-maintenance-intent to dune opam fileschore: add x-maintenance-intent to dune opam filesJan 23, 2025
@maiste
Copy link
Collaborator

I encounter an issue while working on this PR. To be able to have the maintenance field indune-project, I need to increase the number of the lang to3.18. If I do so, it will build the maintenance field, but it will complain that it can't installdune >= 3.18 because this version does not exist in the local switch test.

Also, it seems that the3.18 version is the one that changed the formatting, so it also requires the formatting to change. Should it be done in a separated PR if possible?

@Leonidas-from-XIV
Copy link
Collaborator

With regards to the switch test, the issue seems to be that the packages are getting pinned to 3.17.1 instead of 3.18:

xdg is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)stdune is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)ordering is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)ocamlc-loc is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dyn is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-site is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-rpc is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-rpc-lwt is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-private-libs is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-glob is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-configurator is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-build-info is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)dune-action-plugin is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)chrome-trace is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)

But I do agree that this PR probably needs to be split into two, one that bumps to 3.17 and adds the formatting and one that bumps to 3.18 and updates the maintenance intent.

maiste reacted with thumbs up emoji

@maiste
Copy link
Collaborator

You are right, let's do it this way 👍

@maistemaiste added the choreSomething that just needs to be done. labelJan 27, 2025
@rgrinbergrgrinbergforce-pushed themaintenance-intent-latest branch from4b63540 to523cdafCompareFebruary 7, 2025 22:53
art-wand others added2 commitsFebruary 18, 2025 11:44
Signed-off-by: ArthurW <arthur@tarides.com>Signed-off-by: Etienne Marais <dev@maiste.fr>
Signed-off-by: Etienne Marais <dev@maiste.fr>
@art-wart-wforce-pushed themaintenance-intent-latest branch from523cdaf to1fb1ec1CompareFebruary 18, 2025 10:45
Copy link
Collaborator

@Leonidas-from-XIVLeonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks good but for now blocked on#11478 as it is experiencing the same CI failures for the same reason.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Leonidas-from-XIVLeonidas-from-XIVLeonidas-from-XIV approved these changes

@rgrinbergrgrinbergrgrinberg approved these changes

Assignees
No one assigned
Labels
choreSomething that just needs to be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@art-w@Leonidas-from-XIV@maiste@rgrinberg
[8]ページ先頭
©2009-2025 Movatter.jp