NotificationsYou must be signed in to change notification settings
Fork493
Star2.9k

Show diff for changed scope#811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

jdevries3133 wants to merge1 commit intooauthlib:master

base:master

Choose a base branch

fromjdevries3133:feat/show-diff-for-changed-scope

Draft

Show diff for changed scope#811

jdevries3133 wants to merge1 commit intooauthlib:masterfromjdevries3133:feat/show-diff-for-changed-scope

Conversation

Copy link

jdevries3133 commentedApr 1, 2022

This is a draft PR to show a clean diff instead of a "splat" of text when a scope
change occurs. According to (my understanding of) RFC 6749 Section A.4, the only
allowed delimiter for oauth scopes is a space character:

A.4.  "scope" Syntax   The "scope" element is defined in Section 3.3:     scope       = scope-token *( SP scope-token )     scope-token = 1*NQCHAR

Therefore, this implementation should be good to go. I updated tests so that
they pass with the change. Looking forward to feedback.

Please note that there could be a possible merge conflict with pr#810, so please
review and merge that less-controversial PR first so that I can resolve those
changes into this draft.

Thanks!