Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor epoch to keep time in its own time scale#280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ChristopherRabotin merged 38 commits intonyx-space:masterfromgwbres:4.0.0-dev-gh-237
Apr 24, 2024

Conversation

ChristopherRabotin
Copy link
Member

Reopening#241

gwbresand others added30 commitsMay 27, 2023 14:44
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Co-authored-by: Chris <ChristopherRabotin@users.noreply.github.com>
Co-authored-by: Chris <ChristopherRabotin@users.noreply.github.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Removed deprecated module
I think there is a bug in the Gregorian initialization because it does account for the hour in the reference epoch.The gregorian initialization and formatter should account for the reference epoch of the time scale.
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Guillaume W. Bresand others added8 commitsSeptember 3, 2023 11:16
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
{:?} for an Epoch now shows the duration in the associated timescale.Signed-off-by: Guillaume W. Bres <guillaume.bres@bertin.group>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
@ChristopherRabotin
Copy link
MemberAuthor

Hi@gwbres I have some design questions for you.

First, importantly, I think that we should merge this as part of version 4.0 and I'll take this opportunity to clean up the code from the what is deprecated, refactor the modules to make them more maintainable (it isn't OK to have 4000 lines in a single module, I just added things continuously and never cleaned this up), and general chores.

Secondly, here are some questions:

  1. In the new implementation proposed here (which I like a lot), theto_time_scale function currently only performs the conversion between time scalesif the original time scale and the new one are different. I think it makes sense that we should avoid computations if we can. But shouldn't we expect the behavior of the code to be the same whether or not we perform this computation? My first thought says "yes" but I'm having second thoughts so I'm interested in what you think. For example, in thets_over_leap_second time series test, the result is different if I add&& false to line 339 of epoch.rs or not.
  2. I'll take advantage of this PR to also fixJ1900 and J2000 references mix up, causing older Julian dates to be wrong #282 raised in the discussions. Any objection to that?

That's all for now. But this time, I really want to pick up this work because the list of issues open keeps growing and I want to resolve them.

@ChristopherRabotinChristopherRabotin mentioned this pull requestMar 29, 2024
@ChristopherRabotin
Copy link
MemberAuthor

Moved to#289

@ChristopherRabotinChristopherRabotin merged commit729160d intonyx-space:masterApr 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ChristopherRabotin@gwbres
[8]ページ先頭
©2009-2025 Movatter.jp