Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.5k
fix(kit): normalize layer directory paths with trailing slashes to support dotted folder names#33858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
|
@nuxt/kit@nuxt/nitro-servernuxt@nuxt/rspack-builder@nuxt/schema@nuxt/vite-builder@nuxt/webpack-buildercommit: |
coderabbitaibot commentedDec 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
WalkthroughThis pull request modifies the loader configuration in Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip ✨ Issue Enrichment is now available for GitHub issues!CodeRabbit can now help you manage issues more effectively:
Disable automatic issue enrichmentTo disable automatic issue enrichment, add the following to your issue_enrichment:auto_enrich:enabled:false Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodSpeed Performance ReportMerging#33858 willimprove performances by 12.17%Comparing Summary
Benchmarks breakdown
Footnotes |
jd-solanki commentedDec 12, 2025
I'm not sure about tests but is it possible to have test case for numbered layers directories? |
danielroe left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice! thank you ❤️
7d50229 intonuxt:mainUh oh!
There was an error while loading.Please reload this page.
jd-solanki commentedDec 12, 2025
Hey@danielroe Is it possible to change order of layers via Benefits:
I would love to have this feature, Should I raise a feature request for this? |
danielroe commentedDec 12, 2025
unfortunately that's not possible with local layers. if you want that, move them out of the |
Uh oh!
There was an error while loading.Please reload this page.
🔗 Linked issue
resolves#33855
🐞 Can't import variables from ordered layers in nuxt config#33855
Nuxt’s auto layer discovery strips the trailing slash from layers/* results.
When a layer folder contains a dot (e.g. 01.base), the resolver interprets it as a file extension instead of a directory and throws:
Cannot find module 'layers/01.base'The change makes Nuxt always keep a trailing slash on auto-detected layer paths, so dotted folders are consistently handled as directories. Fairly simple, straight forward fix.
Cheers!