Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.4k
refactor(nuxt): generate valid references for component declaration items#33388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
|
.default
instead of['default']
for component declarations?relative(baseDir,c.filePath).replace(NON_VUE_RE,'') | ||
:c.filePath.replace(NON_VUE_RE,''),{wrapper:false}) | ||
}['${c.export}']` | ||
}${genPropertyAccess(c.export)}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about insteadgenDynamicTypeImport
for knitwork? and it could then specify the property to access as part of that command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea!
Uh oh!
There was an error while loading.Please reload this page.
🔗 Linked issue
📚 Description
typeof import('...').default
is a valid reference compared totypeof import('...')['default']
. It is required to implement the secondary jump for Go to References.Waiting forunjs/knitwork#125.