Deploying with    Cloudflare Pages

View logs

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(8701991) 68.20% compared to head(14ee03f) 68.22%.

@@            Coverage Diff             @@##             main    #1224      +/-   ##==========================================+ Coverage   68.20%   68.22%   +0.01%==========================================  Files          76       76                Lines        4299     4308       +9       Branches      397      398       +1     ==========================================+ Hits         2932     2939       +7- Misses       1339     1340       +1- Partials       28       29       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Actually, thinking about this I'm not 100% sure this is the right choice. Even with statically generated builds, we don't know that all images will be optimised at build time. (For example, they may be loading them in from an API.)

I think it's safer to have users opt-in to this behaviour.

Vercel default config does not allow external URLs by default and we can detect this at build time using config if we want to allow this also automatically.

Build-time cost, is always less than on demand and we can use build-time caching and for staticly build-websites by default, we optimize only build-time images (again unless configured to allow external domain)

The point is that we can optimise all images that areknown at generate time, and for plenty of websites that is perfect 👌

But for websites that have any kind of dynamic image which might rely on the current behaviour, this would be a breaking change. That's why I'm suggesting it should be opt-in.