Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork15
Extending the python support to 3.13 and 3.14#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
SwayamInSync commentedAug 26, 2025
@ngoldbaum wheels building and tests are running fine for 3.13 and 3.14, you can have a look (just some small workflow changes) |
ngoldbaum commentedAug 26, 2025
I edited the PR description since we would still need to fix the release automation to close#130.
Is this an allusion to free-threaded support? You would need to add 3.13t and 3.14t builds to get free-threaded support. You've only added GIL-enabled 3.13 and 3.14 builds here. I think you'd also need to declare free-threaded support in the extension too, otherwise the GIL will get enabled at runtime. Seehttps://py-free-threading.github.io/porting-extensions/#declaring-free-threaded-support. Probably worth adding |
SwayamInSync commentedAug 26, 2025
I see, this make sense. Thanks for the pointers@ngoldbaum, will update the PR here after incorporating and testing this all on personal fork |
SwayamInSync commentedAug 26, 2025
It seems the extension needs to be edited here, let's add this too in the tracker to keep the updates |
SwayamInSync commentedAug 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It seems to be working as expected,@ngoldbaum please take a look
We may need to expand the testing to cover thread-safety better |
juntyr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
1d48f34 intonumpy:mainUh oh!
There was an error while loading.Please reload this page.
ngoldbaum commentedAug 27, 2025
Thanks, now we just need to fix the release automation to make sure the sdist gets uploaded and then do a release! |
SwayamInSync commentedAug 27, 2025
You mean within CI uploading sdist along with artifacts for every release? |
ngoldbaum commentedAug 27, 2025
yup! The wheels and sdist should be uploaded together once they're all built. I can point you at some examples in other repos if you need one. |
Uh oh!
There was an error while loading.Please reload this page.
towards fixing#130