Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Extending the python support to 3.13 and 3.14#134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ngoldbaum merged 17 commits intonumpy:mainfromSwayamInSync:main
Aug 27, 2025

Conversation

@SwayamInSync
Copy link
Member

@SwayamInSyncSwayamInSync commentedAug 26, 2025
edited by ngoldbaum
Loading

towards fixing#130

@SwayamInSync
Copy link
MemberAuthor

@ngoldbaum wheels building and tests are running fine for 3.13 and 3.14, you can have a look (just some small workflow changes)
Tests for matmul uses multithreading so for now it seems to work, maybe will add more extensive tests later

@ngoldbaum
Copy link
Member

I edited the PR description since we would still need to fix the release automation to close#130.

Tests for matmul uses multithreading so for now it seems to work

Is this an allusion to free-threaded support? You would need to add 3.13t and 3.14t builds to get free-threaded support. You've only added GIL-enabled 3.13 and 3.14 builds here.

I think you'd also need to declare free-threaded support in the extension too, otherwise the GIL will get enabled at runtime. Seehttps://py-free-threading.github.io/porting-extensions/#declaring-free-threaded-support.

Probably worth addingpytest-run-parallel testing on the free-threaded build to the CI if you want to add free-threaded support.

@SwayamInSync
Copy link
MemberAuthor

I see, this make sense. Thanks for the pointers@ngoldbaum, will update the PR here after incorporating and testing this all on personal fork

@SwayamInSync
Copy link
MemberAuthor

************************** pytest-run-parallel report **************************  All tests were run in parallel! 🎉  ============================ no tests ran in 0.34s =============================  ! _pytest.outcomes.Exit: GIL was dynamically re-enabled during test collection to load module 'numpy_quaddtype._quaddtype_main'. When running under a free-threaded interpreter with the GIL initially disabled, the test suite must not cause the GIL to be re-enabled at runtime. Check for compiled extension modules that do not use the 'Py_mod_gil' slot or the 'PyUnstable_Module_SetGIL' API. !

It seems the extension needs to be edited here, let's add this too in the tracker to keep the updates

@SwayamInSync
Copy link
MemberAuthor

SwayamInSync commentedAug 27, 2025
edited
Loading

It seems to be working as expected,@ngoldbaum please take a look

  • Addedpytest-run-parallel for 3.13t and 3.14t
  • Updated the extension

We may need to expand the testing to cover thread-safety better

Copy link
Contributor

@juntyrjuntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ngoldbaumngoldbaum merged commit1d48f34 intonumpy:mainAug 27, 2025
6 checks passed
@ngoldbaum
Copy link
Member

Thanks, now we just need to fix the release automation to make sure the sdist gets uploaded and then do a release!

@SwayamInSync
Copy link
MemberAuthor

Thanks, now we just need to fix the release automation to make sure the sdist gets uploaded and then do a release!

You mean within CI uploading sdist along with artifacts for every release?

@ngoldbaum
Copy link
Member

yup! The wheels and sdist should be uploaded together once they're all built. I can point you at some examples in other repos if you need one.

SwayamInSync reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ngoldbaumngoldbaumAwaiting requested review from ngoldbaum

1 more reviewer

@juntyrjuntyrjuntyr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwayamInSync@ngoldbaum@juntyr

[8]ページ先頭

©2009-2025 Movatter.jp