Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add install from source instructions#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ngoldbaum merged 1 commit intonumpy:mainfrommhvk:install-from-source
Mar 5, 2025

Conversation

mhvk
Copy link
Contributor

I thought I would give the quad dtype a try. It was giving errors (will raise separate issue), so I thought I should perhaps install from source. That doesn't really help, but as it took me a while to figure out how to do it, it seemed a good idea to add instructions to theREADME. Note that this is super linux-centric, but perhaps better than nothing?

@ngoldbaum
Copy link
Member

Fun, not sure why the test is failing, but it's unrelated.

@SwayamInSync would you mind giving this a look? If not I'll try diving in here a bit tomorrow (and see if I can reproduce@mhvk's crash).

@mhvk
Copy link
ContributorAuthor

OK, sounds good. Note that I basically started from the github workflow; great that you had that!

@SwayamInSync
Copy link
Contributor

Fun, not sure why the test is failing, but it's unrelated.

@SwayamInSync would you mind giving this a look? If not I'll try diving in here a bit tomorrow (and see if I can reproduce@mhvk's crash).

Sure, I'll give this a go this weekend, a possible hunch is that Sleef got some updates recently (didn't followed them thoroughly) but that can be a possibility of crash.
Thanks@mhvk we will check and fix it :)

@mhvk
Copy link
ContributorAuthor

@SwayamInSync - thanks! As for sleef, after I installed sleef on my machine, I did run the tests and they all passed.

@SwayamInSync
Copy link
Contributor

Quick fix and issue

I see, my suspection seems to be correct, it was indeed version changing issues (and a pretty interesting one)
We build this with the 3.6 version of Sleef and now currently ongoing in 3.8

So I changed the version back to 3.6 in my fork and it passed all the tests

git clone -b 3.6 https://github.com/shibatch/sleef.git

Now fun part:

The issue is in the that test too, the test checks for thenan as

assert (QuadPrecision("nan")!=QuadPrecision("nan"))== (QuadPrecision("nan")==QuadPrecision("nan"))

A simplified version would be

(nan!=nan)== (nan==nan)

As per IEEE-754 this should evaluate to

(nan!=nan)# True(nan==nan)# False# so overallTrue==False

So the previous version (3.6) was IEEE incorrect (passing that test) and which when fixed in 3.8 made the error

so the correct test should be

deftest_nan_and_inf():# NaN should not equal itselfassertQuadPrecision("nan")!=QuadPrecision("nan")# Test infinity comparisonsassertQuadPrecision("inf")>QuadPrecision("1e1000")assertQuadPrecision("-inf")<QuadPrecision("-1e1000")

@ngoldbaum another reason we should plan a tlfloat backend :)

mhvk reacted with thumbs up emoji

@mhvkmhvkforce-pushed theinstall-from-source branch from5fcc602 to6e83f1cCompareMarch 2, 2025 20:09
@mhvk
Copy link
ContributorAuthor

mhvk commentedMar 2, 2025

I now checked on my laptop and it turns out my installation instructions had some typos and had aftereffects of experimenting with environment variables. I corrected these.

@ngoldbaum
Copy link
Member

Thanks@mhvk, let's fix the failing CI in a separate PR.

@ngoldbaumngoldbaum merged commitce8c26b intonumpy:mainMar 5, 2025
1 check failed
@mhvkmhvk deleted the install-from-source branchMarch 5, 2025 21:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mhvk@ngoldbaum@SwayamInSync

[8]ページ先頭

©2009-2025 Movatter.jp