Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updating Quaddtype#102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ngoldbaum merged 33 commits intonumpy:mainfromSwayamInSync:dragon4
Sep 22, 2024
Merged

Updating Quaddtype#102

ngoldbaum merged 33 commits intonumpy:mainfromSwayamInSync:dragon4
Sep 22, 2024

Conversation

SwayamInSync
Copy link
Contributor

This PR updates the following to quaddtype

  • Support for secondlongdouble backend
  • more unary and binary funcs
  • renamed tonumpy_quaddtype
  • Dragon4 printing

and more small refactors

Copy link
Member

@ngoldbaumngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did not carefully review all the reference counting or go over everything with a fine-toothed comb but I did go over the whole thing and followed along with the structure.

Overall this looks really nice. I think there are some clear paths to improve it, but that's always going to be the case and this is already far enough along that once we have some basic docs written we can try inviting people to test it and start thinking about a NEP to do something about np.128.

SwayamInSync reacted with heart emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not needed for this PR, but it would be nice to get proper docstrings for all the types and functions that are visible to python. Also a small module-level docstring showing basic usage.

else {
result.longdouble_value = x;
}
return result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not needed for this PR, but the repeated boilerplate above is a good place to use a template function IMO

}
else {
return x.longdouble_value;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it would be simpler to template over backend and output type, then you wouldn't need the runtime branching.

@ngoldbaumngoldbaum merged commit79e5ea2 intonumpy:mainSep 22, 2024
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ngoldbaumngoldbaumngoldbaum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SwayamInSync@ngoldbaum

[8]ページ先頭

©2009-2025 Movatter.jp