Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Packaging QuadDType#100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SwayamInSync wants to merge185 commits intonumpy:main
base:main
Choose a base branch
Loading
fromSwayamInSync:quaddtype-packaging

Conversation

SwayamInSync
Copy link
Contributor

This PR adds the workflow for building wheels and making release forquaddtype

@@ -1,20 +1,72 @@
project('quaddtype', 'c', 'cpp', default_options : ['cpp_std=c++17', 'b_pie=true'])
project('quaddtype', 'c', 'cpp', default_options : ['cpp_std=c++20', 'b_pie=true'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why C++20?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Getting this error in windows build (MSVC)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if that will be problematic on visual studio 2019, which is still supported aiui. If it's not an issue here on CI I think it's fine, definitely something to check about with someone who has more experience distributing wheels that depend on C++ code.

- uses: actions/upload-artifact@v3
with:
path: ./quaddtype/wheelhouse/*.whl
name: wheels-windows-${{ matrix.architecture }}
Copy link
Member

@ngoldbaumngoldbaumAug 28, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I noted the duplication about the test commands, but there's a lot of other duplication as well. Can you try to unify the logic a bit? I think in principle you could make the Mac and Linux builds identical, only conditionally setting a few environment variables differently. The Windows build needs it own separate build section, but I don't think the dependency setup, testing, or upload steps need to be repeated.

It's OK to have architecture-specific steps within a longer workflow by branching on the build platform in the build matrix like e.g.if: matrix.platform == 'win32'.

commit1a6618aAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 22 02:19:59 2024 +0530    missed the comma :)commit87a7891Author: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 22 02:16:24 2024 +0530    updated meson.buildcommit77e25b6Author: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 22 00:53:57 2024 +0530    made ufunc return actual value instead of 0commit600b2c8Author: swayaminsync <hawkempire007@gmail.com>Date:   Sat Sep 21 03:06:36 2024 +0530    fixed inter-backend cast segment faultcommit672be17Author: swayaminsync <hawkempire007@gmail.com>Date:   Sat Sep 21 00:01:39 2024 +0530    added aligned and unaligned casting loopscommit2fd9cadAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 20 21:00:45 2024 +0530    refactoringcommit41ca3f9Author: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 20 20:58:08 2024 +0530    added 128-bit common constantscommit012e90fMerge:082b64bbbc99a6Author: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 20 19:30:53 2024 +0530    Merge branch 'dragon4' into constantscommitbbc99a6Author: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 20 19:27:55 2024 +0530    fixing constant errorcommite53edbaAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 20 17:03:24 2024 +0530    resolved reviewscommit082b64bAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Thu Sep 19 21:43:48 2024 +0530    exposing constantscommit0052e16Author: swayaminsync <hawkempire007@gmail.com>Date:   Thu Sep 19 13:17:01 2024 +0530    Creating Quad with Quadcommit0a75b91Author: swayaminsync <hawkempire007@gmail.com>Date:   Wed Sep 18 15:39:46 2024 +0530    aligned and unaligned comparison loopscommit707d5d6Author: swayaminsync <hawkempire007@gmail.com>Date:   Wed Sep 18 13:47:32 2024 +0530    fixed longdouble comparison casting issuecommit4f0a604Author: swayaminsync <hawkempire007@gmail.com>Date:   Tue Sep 17 21:51:17 2024 +0530    WIPcommit0fba040Author: swayaminsync <hawkempire007@gmail.com>Date:   Tue Sep 17 18:01:14 2024 +0530    added separate aligned and unaligned ufunc supportcommitfe6cabcAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 16 18:40:47 2024 +0530    removed unnecessary printscommitb719ba4Author: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 16 18:35:54 2024 +0530    fixing import statementscommit25dd6b3Author: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 16 18:02:42 2024 +0530    removing testing filescommit0ac5464Author: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 16 15:16:12 2024 +0530    added more unary funccommit755e2cdAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Tue Sep 10 08:30:15 2024 +0530    fixing basecommit04480ceAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Sat Sep 7 18:23:20 2024 +0530    np.dot WIPcommit7b43f3bAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Sat Sep 7 12:58:45 2024 +0530    fixing reduction redorderable issuecommit22982a4Author: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 6 19:09:12 2024 +0530    adding dragon4commit01e9b7eAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Fri Sep 6 12:04:01 2024 +0530    post-cleaningcommite8cba6aAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Thu Sep 5 14:58:47 2024 +0530    temporary solution to handle both backendscommit7a85fbfAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 2 00:24:29 2024 +0530    removed todo comment: umath.cppcommitd664a59Author: swayaminsync <hawkempire007@gmail.com>Date:   Mon Sep 2 00:23:12 2024 +0530    added backend parameter in default descriptorcommit7fd8da6Author: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 1 21:14:11 2024 +0530    failing: londouble with different dtypecommita652985Author: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 1 12:34:59 2024 +0530    added multi backend support to scalar operationscommit8408227Author: swayaminsync <hawkempire007@gmail.com>Date:   Sun Sep 1 04:17:31 2024 +0530    added ld backend support to castingcommitd56e592Author: swayaminsync <hawkempire007@gmail.com>Date:   Sat Aug 31 22:37:00 2024 +0530    renaming module and adding initial longdouble backend supportcommit0a36a9dAuthor: swayaminsync <hawkempire007@gmail.com>Date:   Sun Aug 25 12:02:33 2024 +0530    added readme
Copy link
Member

@ngoldbaumngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All the build changes look much cleaner now, thanks for removing all the hardcoding. I'm glad you were able to get the wheel builds working as well.

Another followup task after this is to create a new feedstock for numpy_quaddtype on conda-forge. Since SLEEF is already packaged that should be straightforward I think. If you've never set up a conda package before I can point you at the relevant docs.

Once that's done and we have wheels up on PyPI I think we can make an announcement on the numpy mailing list asking for feedback.

user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
packages-dir: dist/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mattip when you have time, can you coordinate with Swayam to add the configuration necessary to upload to pypi athttps://pypi.org/project/numpy_quaddtype/? I thinkthese are the relevant docs.

@SwayamInSync you should also probably manually upload a numpy_quaddtype release to pypi with a tarball containingnthe current state of the main branch. Mostly just to claim the name, but I think the project may have to exist already on pypi before you can set up trusted publishing.

@SwayamInSync
Copy link
ContributorAuthor

All the build changes look much cleaner now, thanks for removing all the hardcoding. I'm glad you were able to get the wheel builds working as well.

Another followup task after this is to create a new feedstock for numpy_quaddtype on conda-forge. Since SLEEF is already packaged that should be straightforward I think. If you've never set up a conda package before I can point you at the relevant docs.

Once that's done and we have wheels up on PyPI I think we can make an announcement on the numpy mailing list asking for feedback.

Yeah make sense, I never set-up a conda package in past, so it'll be very helpful with the relevant docs :)

@ngoldbaum
Copy link
Member

I'll try to look at this again soon, sorry for letting it fall of my radar.

SwayamInSync reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ngoldbaumngoldbaumngoldbaum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SwayamInSync@ngoldbaum
[8]ページ先頭
©2009-2025 Movatter.jp