Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork196
Added myst version of x-ray tutorial.#49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered byReviewNB |
Uh oh!
There was an error while loading.Please reload this page.
README.md Outdated
| @@ -19,6 +19,7 @@ or navigate to any of the documents listed below and download it individually. | |||
| 2. [Tutorial: CS231n Python Tutorial](content/cs231_tutorial.md) | |||
| 3. [Tutorial: Determining Moore's Law with real data in NumPy](content/mooreslaw-tutorial.ipynb) | |||
| 4. [Tutorial: Saving and sharing your NumPy arrays](content/save-load-arrays.ipynb) | |||
| 5. [Tutorial: X-ray image processing](content/tutorial-x-ray-image-processing.md) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@melissawm Just noticed that the MNIST tutorial is also 5th in the list fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I was waiting for that one to be merged to fix this, thanks for catching that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I took the liberty of adding the missingimageio dependency so that the CI can run successfully (we may need to adjust themyst_nb config params so that failed notebook execution fails more loudly!)
Just some comments on a few MyST gotchas, mostly related to markdown being picky about dashes/numbers & spacing.
I limited my comments to the format-specific stuff and not the content of the tutorial itself - I'll take another pass once this is merged so that I can add comments with the new workflow!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM (once the merge conflict is resolved)! Thanks@melissawm &@8bitmp3 for taking the lead on the workflow conversion here,
@8bitmp3 please check - I had to do some tweaking to the format to make it work with MyST.
One problem remains: the gif is not showing properly. I'm trying to find a solution to this.