Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork196
MAINT: update minimum required versions and CI maintanance#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3628875
to1fc42cc
Comparecbb8e22
to58556ae
Compare
rossbar left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@bsipocz for the updates.
Instead of skipping the mooreslaw building, what about merging#182 instead to get rid of the statsmodels dependency. I think the motivation for#182 was already strong, but now that statsmodels is holding pinning us so far back from development numpy I think the motivation is even stronger
It looks like we'reon the same page 🚀
Uh oh!
There was an error while loading.Please reload this page.
Keep reinstalling numpy with a separated pip command to ensure the dev version is picked up even if a downstream dependency upper limited it
58556ae
tof375a5c
CompareOK, so this is now rebased and should have passing jobs with the exception of the conda ones. A debug session and hopeful fix will come for those separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks@bsipocz !
Uh oh!
There was an error while loading.Please reload this page.
I'll also use this PR tofix#190
I'm happy to separate the PR into two, one to bump the minimum versions following SPEC0 and the other to update and fix the devdeps job