Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix 1.9 alignment#5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@charris
Copy link
Member

Backport of#5316 with potential modification suggested by Julian. After review, extra commit willl be squashed.

If itemsize is a power of two use that as the required alignment up tothe maximum provided by the platform. Power of two sizes may be accessedvia larger moves than bytes.Non-power of two sizes are accessed bytewise and can thus always beconsidered aligned.Closesnumpygh-5293
malloc only provides 8byte alignment and is sufficient to load complexon x86 platforms.This fixes the f2py alignment failures with complex types on win32 or onlinux32 with -malign-double
@charris
Copy link
MemberAuthor

@juliantaylor Could you check this?

@charris
Copy link
MemberAuthor

OK remove 'fixup'.

@juliantaylor
Copy link
Contributor

looks ok, I'll probably backport some more minor stuff this weekend and then we can do a 1.9.2

@juliantaylor
Copy link
Contributor

note I don't know when I'll finish the other fix, I tend to look at the duplication in raw_assign* get anoyed and stop, and I'm also to lazy to actually try to homogenize it ;)

juliantaylor added a commit that referenced this pull requestJan 25, 2015
Fix too large alignment of complex types
@juliantaylorjuliantaylor merged commit1cac77b intonumpy:maintenance/1.9.xJan 25, 2015
@charrischarris deleted the fix-1.9-alignment branchFebruary 17, 2015 19:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charris@juliantaylor

[8]ページ先頭

©2009-2025 Movatter.jp