Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
BUG: fix not returning out array from ufuncs with subok=False set#5242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
numpy/core/src/umath/ufunc_object.c Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Umm, wrap what? Why put None into the out argument slots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
None is the value used to indicate to return the output argument NULL is create a new return array viaPyArray_Return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, might add that to the comment.
6016402 tob40e686Comparecharris commentedOct 28, 2014
Thanks Julian. I needed a PR I could commit ;) |
BUG: fix not returning out array from ufuncs with subok=False set
BUG: fix not returning out array from ufuncs with subok=False set
mhvk commentedOct 29, 2014
Thanks for solving it so quickly. Just in case: Since you had milestone 1.9.1 for#5240, should it be set here as well, as a reminder to add it to that branch? |
juliantaylor commentedOct 29, 2014
I have already pushed the commit to the branch |
closesgh-5240