Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
DOC: Correct wording usage such as a/an#30390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Diff frommypy_primer, showing the effect of this PR on type check results on a corpus of open source code: pandas (https://github.com/pandas-dev/pandas)- /home/runner/work/numpy/numpy/numpy_base/numpy/__init__.pyi:740: error: Type statement is only supported in Python 3.12 and greater [syntax]+ /home/runner/work/numpy/numpy/numpy_to_test/numpy/__init__.pyi:740: error: Type statement is only supported in Python 3.12 and greater [syntax] |
jakevdp commentedDec 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Part of this depends on how you read it: e.g. I tend to read "a np.ndarray" as "a numpy-dot-ndarray", so "a" is gramatically the right choice. However, if you read it as "a en-pee-dot-ndarray", then I could see wanting to switch "a" to "an". But the ambiguity suggests that replacing "a" with "an" everywhere is probably not worth worrying about. |
Correct wording usage such as a/an.
I searched for patterns such as
" a np"and" a nd"in the GitHub codebase, because they are most likely to contain grammatical mistakes. Then I manually reviewed which ones needed to be changed. These patterns are not exhaustive, so a few issues of ("a" vs "an") still remain.The correct usages are
"a np"and"an nd", because the phonetic spelling of the word starts with a vowel.https://www.grammarly.com/blog/grammar/indefinite-articles-a-and-an/
I intentionally did not include
[skip actions][skip azp][skip cirrus]in the commit, because one change is in the error message.