Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
Bug: Fix PPC64 native/POWER10 baseline builds#30372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
seiko2plus wants to merge2 commits intonumpy:mainChoose a base branch fromseiko2plus:fix-hwy-ppc-native-bld
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ba5b9a8 to9c6b46aCompareWide versions of GCC (≤13) produce ambiguous bugs with compiler target attributes when`-mcpu/host` flags are provided via environment variables or via Meson build,leading to an inability to raise the default baseline to POWER10.This is fixed by enabling the newly added Highway option `-DHWY_DISABLE_ATTR` to address the issue,as reported to Highway. This patch also fixes the Clang build bug reported by explicitlyadding `-mvsx` along with `-mcpu`.
9c6b46a toc1582d4CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wide versions of GCC (≤13) produce ambiguous bugs with compiler target attributes when
-mcpu/hostflags are provided via environment variables or via Meson build,leading to an inability to raise the default baseline to POWER10.
This is fixed by enabling the newly added Highway option
-DHWY_DISABLE_ATTRto address the issue,as reported to Highway. This patch also fixes the Clang build bug reported by explicitly
adding
-mvsxalong with-mcpu.