Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: Fix RecursionError by ignoring strings in dependency checks#30363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Rupeshhsharma wants to merge5 commits intonumpy:main
base:main
Choose a base branch
Loading
fromRupeshhsharma:fix-#28700

Conversation

@Rupeshhsharma
Copy link
Contributor

Fix#28700
Please let me know if my approach or fix needs any improvements. I'm open to feedback and happy to make changes based on suggestion.
Thankyou!

Comment on lines 2879 to 2880
rhs=re.sub(r"('.*?')",'',rhs)
rhs=re.sub(r'(".*?")','',rhs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

these regexes can be combined

Rupeshhsharma reacted with thumbs up emoji
@jorenhamjorenham changed the titleFix RecursionError by ignoring strings in dependency checksBUG: Fix RecursionError by ignoring strings in dependency checksDec 4, 2025
@seberg
Copy link
Member

It would be good to add a test.

I am wondering if this is the right spot. This code is unfortunately so messy it is hard to tell. I could see pushing it down to where the recursion happens in_get_depend_dict, but maybe@m-weigand thought on improving thename_match = re.compile(r'[A-Za-z][\w$]*').match is actually nicer?

(I haven't fully understood where other type of constants are figured out,_get_depend_dict has a code comment basically admitting to it being wrong? Theisstring doesn't match for some reason, and if the variable name and the text constant have the same content things will recurse infinitely, because it thinks that it depends on itself -- or another variable for that matter.)

Rupeshhsharma reacted with thumbs up emoji

@seberg
Copy link
Member

Ping@HaoZeke, although I am not sure you have time to look at f2py issues these days.

@HaoZeke
Copy link
Member

HaoZeke commentedDec 6, 2025 via email

Sorry, graduating on the 19th, so am blocked until then. Will push a bunch of stuff through by the end of the year. On Friday, December 5, 2025 at 03:42:44 AM EST, Sebastian Berg ***@***.***> wrote: seberg left a comment (numpy/numpy#30363)Ping@HaoZeke, although I am not sure you have time to look at f2py issues these days.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
seberg and Rupeshhsharma reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jorenhamjorenhamjorenham left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: f2py treats f90 module strings as variable names for dependent variables

4 participants

@Rupeshhsharma@seberg@HaoZeke@jorenham

[8]ページ先頭

©2009-2025 Movatter.jp