Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
BUG: Fix RecursionError by ignoring strings in dependency checks#30363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
numpy/f2py/crackfortran.py Outdated
| rhs=re.sub(r"('.*?')",'',rhs) | ||
| rhs=re.sub(r'(".*?")','',rhs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
these regexes can be combined
seberg commentedDec 4, 2025
It would be good to add a test. I am wondering if this is the right spot. This code is unfortunately so messy it is hard to tell. I could see pushing it down to where the recursion happens in (I haven't fully understood where other type of constants are figured out, |
seberg commentedDec 5, 2025
Ping@HaoZeke, although I am not sure you have time to look at f2py issues these days. |
HaoZeke commentedDec 6, 2025 via email
Sorry, graduating on the 19th, so am blocked until then. Will push a bunch of stuff through by the end of the year. On Friday, December 5, 2025 at 03:42:44 AM EST, Sebastian Berg ***@***.***> wrote: seberg left a comment (numpy/numpy#30363)Ping@HaoZeke, although I am not sure you have time to look at f2py issues these days.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> |
Fix#28700
Please let me know if my approach or fix needs any improvements. I'm open to feedback and happy to make changes based on suggestion.
Thankyou!