Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
DOC: Expand/clean up extension module import error#29036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
seberg wants to merge4 commits intonumpy:mainChoose a base branch fromseberg:cmodule-import-info
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+46 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We get a lot of these reports and it is never us... But unfortunately,Python (currently) doesn't report *why* the module wasn't found.(I have opened an issue asking for that.)Until Python does, try to figure it out ourselves, i.e. list C modules(I guess its always one, but OK).If anything it'll give *us* an immediate thing to point out if anissue is reported...I also hid the "source import" thing to only occur if __config__doesn't exist. Not sure that catches this fully, but I also feellike this isn't an actual problem anymore (i.e. we could just deleteit also).Tested locally by renaming or deleting `_multiarray_umath`.
hey, there's got a seggo again 🎉 |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get a lot of these reports and it is never us... But unfortunately, Python (currently) doesn't reportwhy the module wasn't found. (I have opened an issue asking for that.)
Until Python does, try to figure it out ourselves, i.e. list C modules (I guess its always one, but OK).
If anything it'll giveus an immediate thing to point out if an issue is reported...
I also hid the "source import" thing to only occur ifconfig doesn't exist. Not sure that catches this fully, but I also feel like this isn't an actual problem anymore (i.e. we could just delete it also).
Tested locally by renaming or deleting
_multiarray_umath
.