Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MAINT: Convert pocketfft_umath to multi-phase init (PEP 489)#29028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
seberg merged 1 commit intonumpy:mainfromAA-Turner:multi-phase/fft
May 29, 2025

Conversation

AA-Turner
Copy link
Contributor

@AA-TurnerAA-Turner commentedMay 21, 2025•
edited
Loading

@AA-TurnerAA-Turnerforce-pushed themulti-phase/fft branch 2 times, most recently from074fb12 to14b4169CompareMay 22, 2025 03:14
@AA-TurnerAA-Turner marked this pull request as draftMay 24, 2025 06:22
@AA-TurnerAA-Turner marked this pull request as ready for reviewMay 28, 2025 13:58
@AA-Turner
Copy link
ContributorAuthor

cc@seberg. We prevent multiple inits because the static function and type arrays are used in thePyUFuncObject structure.

A

Copy link
Member

@sebergseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine with the decref fixed.

FWIW, while I think it's likely a bad idea to create these ufuncs multiple times, I don't actually think it's a problem and this module is actually safe to delete and reload.

(Not saying it will actually get all cleaned up, I would be surprised, but for the most part.)

@AA-Turner
Copy link
ContributorAuthor

Looks fine with the decref fixed.

Sorry for that, remnants of experimentation.

@AA-Turner
Copy link
ContributorAuthor

FWIW, while I think it's likely a bad idea to create these ufuncs multiple times, I don't actually think it's a problem and this module is actually safe to delete and reload.

Fair enough, I admit I haven't tried. I think keeping this PR as-is and looking to relax the restriction in a followup may be prudent, though?

@sebergseberg changed the titleGH-29021: Convert pocketfft_umath to multi-phase init (PEP 489)MAINT: Convert pocketfft_umath to multi-phase init (PEP 489)May 29, 2025
NULL, /* m_doc */
0, /* m_size */
NULL, /* m_methods */
_pocketfft_umath_slots, /* m_slots */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now that I scroll through, I would have liked to use.m_base =, etc. but a cleanup for another day.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Designated initialisers are only supported for C++20 -- hence the legacy style.

A

seberg reacted with thumbs up emoji
@sebergseberg merged commit5ab56f6 intonumpy:mainMay 29, 2025
74 checks passed
@AA-TurnerAA-Turner deleted the multi-phase/fft branchMay 29, 2025 08:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sebergsebergseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AA-Turner@seberg
[8]ページ先頭
©2009-2025 Movatter.jp