Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
ENH: Disable the alloc cache under address and memory sanitizers#29006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+16 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We've been carrying a variant of this patch in our local copy of NumPyfor some time. The alloc cache reduces the effectiveness ofuse-after-free or use-of-uninitialized memory warnings because cachingof allocations means they may be reused for a different allocation,potentially hiding real problems.
Seems reasonable to me.@ngoldbaum Thoughts? |
Seems reasonable to me as well. |
0506cf6 intonumpy:main 74 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@hawkinsp . |
seberg added a commit to seberg/numpy that referenced this pull requestMay 23, 2025
numpygh-29006 got the branching wrong leaving the cache undefined on mostGCC/clang, which means we wouldn't use it.Also move it up so that we can just remove the unused globals entirely.
seberg added a commit to seberg/numpy that referenced this pull requestMay 23, 2025
numpygh-29006 got the branching wrong leaving the cache undefined on mostGCC/clang, which means we wouldn't use it.Also move it up so that we can just remove the unused globals entirely.
charris pushed a commit to charris/numpy that referenced this pull requestMay 23, 2025
numpygh-29006 got the branching wrong leaving the cache undefined on mostGCC/clang, which means we wouldn't use it.Also move it up so that we can just remove the unused globals entirely.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been carrying a variant of this patch in our local copy of NumPy for some time.
The alloc cache reduces the effectiveness of use-after-free or use-of-uninitialized memory warnings because caching of allocations means they may be reused for a different allocation, potentially hiding real problems.