Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: Use isinstance() instead of comparing type()#28984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jorenham merged 2 commits intonumpy:mainfromDimitriPapadopoulos:type==
May 16, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Not entirely equivalent, in case of derived classes. Yet, I believe the new behaviour is the desired behaviour.

@DimitriPapadopoulosDimitriPapadopoulos changed the titleMNT: Use ininstance() instead of comparing type()MNT: Use isinstance() instead of comparing type()May 16, 2025
Not entirely equivalent, in case of derived classes. Yet, I believethe new behaviour is the desired behaviour.
@DimitriPapadopoulosDimitriPapadopoulosforce-pushed thetype== branch 3 times, most recently fromeacd058 to8abf3d9CompareMay 16, 2025 10:03
Copy link
Member

@jorenhamjorenham left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These seems safe enough. And in case anp.bytes_ is now passed asbytes, I believe it would (still?) work.

@jorenhamjorenham merged commit5fe514b intonumpy:mainMay 16, 2025
74 checks passed
@DimitriPapadopoulosDimitriPapadopoulos deleted the type== branchMay 16, 2025 16:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jorenhamjorenhamjorenham approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DimitriPapadopoulos@jorenham
[8]ページ先頭
©2009-2025 Movatter.jp