this is a no-op:

>>>import copy>>>classA:...... >>> copy.copy(A)is ATrue

and it's the same story withcopy.deepcopy:

>>> copy.deepcopy(A)is ATrue

Thanks for pointing that, just got to realize that copy is a little bit subtle.

The intention of the copy was to not introducing any side effect, even while running on the documentation.
Now, the whole thing about changing__module__ is about its side effect and, as discussedpreviously it was needed downstream.

Since this code is running while generating the docs, do you think we could just recover the original__module__ without further problems?

Since this code is running while generating the docs, do you think we could just recover the original__module__ without further problems?

I guess that depends on whether the docs currently (also) use the patched__module__ somewhere, and if so, where/when that happens. Put differently; it shouldn't be a problem if it doesn't also change the documented module paths.

But I'm not very familiar with this doc generation code, so it's probably best if another maintainer could chime in here.

As long as the docs build fine and there aren't any other regressions introduced it should be fine. You could try looking at a diff of the docs build before and after applying the change to see what changes.

It looks like there are some new warnings in the docs build - those need to be fixed too.

Ok. I will take a look at this and give the feedback here.

@jorenham and@ngoldbaum.

This is ready for review.