Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: Fix missing check for PyErr_Occurred() in _pyarray_correlate.#28916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfromcharris:backport-28898
May 6, 2025

Conversation

charris
Copy link
Member

Backport of#28898.

When running the scipy 1.15 test suite test
signal/tests/test_signaltools.py::test_lfilter_bad_object, with Python built in debug mode, we see the following error:

Fatal Python error: _Py_CheckSlotResult: Slot * of type float succeeded with an exception set

None ends up as the first argument todot, and this triggers an error from PyFloat_Multiply. Once an error has occurred, we must avoid calling multiply again, since it asserts that PyErr_Occurred() is false if the output is a non-error, which will fail if an error was set at entry.

…umpy#28898)When running the scipy 1.15 test suite testsignal/tests/test_signaltools.py::test_lfilter_bad_object, with Pythonbuilt in debug mode, we see the following error:```Fatal Python error: _Py_CheckSlotResult: Slot * of type float succeeded with an exception set````None` ends up as the first argument to `dot`, and this triggers anerror from PyFloat_Multiply. Once an error has occurred, we must avoidcalling multiply again, since it asserts that PyErr_Occurred() is falseif the output is a non-error, which will fail if an error was set atentry.
@charrischarris added this to the2.2.6 release milestoneMay 6, 2025
@charrischarris added 00 - Bug 08 - BackportUsed to tag backport PRs labelsMay 6, 2025
@charrischarris merged commit4277e7c intonumpy:maintenance/2.2.xMay 6, 2025
70 checks passed
@charrischarris deleted the backport-28898 branchMay 6, 2025 22:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug08 - BackportUsed to tag backport PRs
Projects
None yet
Milestone
2.2.6 release
Development

Successfully merging this pull request may close these issues.

2 participants
@charris@hawkinsp

[8]ページ先頭

©2009-2025 Movatter.jp