Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MAINT: from_dlpack thread safety fixes#28883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
seberg merged 2 commits intonumpy:mainfromngoldbaum:from-dlpack-globals
May 2, 2025

Conversation

ngoldbaum
Copy link
Member

@ngoldbaumngoldbaum commentedMay 1, 2025•
edited
Loading

Fixes#28881

Moves the global variables defined infrom_dlpack to thenpy_static_pydata struct and initializes them during module init.

Copy link
Member

@sebergseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM if tests pass, although adding a prefix likedl_ ordlpack_ would be better.

@seberg
Copy link
Member

Thanks Nathan, save to backport, not sure if we want to.

@sebergseberg merged commitaa7c4f5 intonumpy:mainMay 2, 2025
73 checks passed
@charrischarris added 08 - BackportUsed to tag backport PRs 09 - Backport-CandidatePRs tagged should be backported and removed 08 - BackportUsed to tag backport PRs labelsMay 2, 2025
charris pushed a commit to charris/numpy that referenced this pull requestMay 2, 2025
Fixesnumpy#28881Moves the global variables defined in from_dlpack to the npy_static_pydata struct and initializes them during module init.
@charrischarris removed the 09 - Backport-CandidatePRs tagged should be backported labelMay 2, 2025
charris added a commit that referenced this pull requestMay 2, 2025
MAINT: from_dlpack thread safety fixes (#28883)
MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull requestMay 8, 2025
Fixesnumpy#28881Moves the global variables defined in from_dlpack to the npy_static_pydata struct and initializes them during module init.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sebergsebergseberg approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: data race in from_dlpack method under free-threading
3 participants
@ngoldbaum@seberg@charris
[8]ページ先頭
©2009-2025 Movatter.jp