Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: discard unused function using os.system()#28876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:mainfromDimitriPapadopoulos:os.system
May 1, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulosDimitriPapadopoulos marked this pull request as ready for reviewMay 1, 2025 10:03
@charrischarris merged commit25340fe intonumpy:mainMay 1, 2025
73 of 74 checks passed
@charris
Copy link
Member

Thanks@DimitriPapadopoulos .

Hmm, I suspect this whole file can be removed. It seems intended to provide system information when dealing with f2py failures. It also has a lot of code dealing with distutils, which is going away.

@DimitriPapadopoulosDimitriPapadopoulos deleted the os.system branchMay 1, 2025 14:33
@DimitriPapadopoulos
Copy link
ContributorAuthor

DimitriPapadopoulos commentedMay 1, 2025•
edited
Loading

Perhaps I shouldn't have removed this after all:

from .importdiagnose

Isn'tnumpy.f2py.diagnose part of the public API?

Not that anyone is necessarily using it, but isn't it part of the API? Perhaps deprecate it first?

@charris
Copy link
Member

Isn't numpy.f2py.diagnose part of the public API?

Yes, and tested for that. The proper procedure to remove the whole file would be to deprecate first.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DimitriPapadopoulos@charris
[8]ページ先頭
©2009-2025 Movatter.jp