Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.8k
TYP: genericStringDType#28856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
TYP: genericStringDType#28856
Conversation
ngoldbaum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably needs some new typing tests too?
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
jorenham commentedApr 29, 2025
It's all pretty straightforward so I didn't think it would be necessary to add additional tests for this. I figured that as long as the current type-tests involving Testing this would also be rather difficult because it involves But if you want to see some test either way, I won't mind adding some 🤷🏻 |
ngoldbaum commentedApr 29, 2025
Eh, no worries. |
01f2fec intonumpy:mainUh oh!
There was an error while loading.Please reload this page.
charris commentedMay 1, 2025
Thanks Joren. |
ported fromnumpy/numtype#335
This also adds the missing
na_objectandcoercekwargs toStringDType.__new__