Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
TYP: fixNDArray[floating] + float
return type#28807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Should I label this as backport candidate, or are there no 2.2.6 plans? |
Diff frommypy_primer, showing the effect of this PR on type check results on a corpus of open source code: vision (https://github.com/pytorch/vision)- torchvision/utils.py:270: error: Unused "type: ignore" comment [unused-ignore] |
the |
2.2.6 plans are ... undecided. Go ahead and mark it. |
5570e92
intonumpy:mainUh oh!
There was an error while loading.Please reload this page.
Thanks Joren. |
For what it's worth; judging by the lack of mypy_primer diffs, I don't consider this to be a high-priority fix. |
Closes#28805