Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
BUG: fix np.genfromtxt for all columns in usecols, in different order.#28802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
HenriqueLLuz wants to merge2 commits intonumpy:mainChoose a base branch fromHenriqueLLuz:bug-fix
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+17 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Resolved an issue in genfromtxt where it produced incorrect resultswhenever it was used all columns in usecols and they were in an orderdifferent than the displayed in the first line. Added a test to ensureaccurate assignment of columns names to the respective columns.(fixesnumpy#28225)
@HenriqueLLuz thanks, sorry that nobody took a look. I have to browse through to make sure this covers everything, but LGTM on first sight. Could you add a brief release note (I guess with |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved an issue in genfromtxt where it produced incorrect results whenever it was used all columns in usecols and they were in an order different than the displayed in the first line. Added a test to ensure accurate assignment of columns names to the respective columns. (fixes#28225).
The issue arose when usecols had all the column names but in different order than the one in the original text. In this case, usecols was not being reordered before assigning data, resulting in data being assign to the wrong column. The reordering only happened when the number of columns of the original text was more than the length of usecols. I just made it to reorder when they have same length too.