Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.8k
TYP: fixcount_nonzero signature#28774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
b3e772c intonumpy:maintenance/2.2.x 69 checks passed
Uh oh!
There was an error while loading.Please reload this page.
MemberAuthor
charris commentedApr 19, 2025
Thanks Joren. |
Member
jorenham commentedApr 19, 2025
Right back at ya |
penguinpee added a commit to penguinpee/numpy that referenced this pull requestSep 25, 2025
The return type of the function was changed in 2.3.0, but the docstringremained the same (numpygh-28774).
penguinpee added a commit to penguinpee/numpy that referenced this pull requestOct 6, 2025
The return type of the function was changed in 2.3.0, but the docstringremained the same (numpygh-28774).
MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull requestOct 13, 2025
The return type of the function was changed in 2.3.0, but the docstringremained the same (numpygh-28774).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of#28750.
This fixes the following valid usage inhttps://github.com/data-apis/array-api-compat/blob/16978e63b744185bc4ced4677c822468e6ddebd2/array_api_compat/numpy/_aliases.py#L126-L127 from being falsely rejected: