Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
ENH: np.unique: support hash based unique for string dtype#28767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
math-hiyoko wants to merge78 commits intonumpy:mainChoose a base branch frommath-hiyoko:feature/#28364
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
78 commits Select commitHold shift + click to select a range
f620f3b
Support NPY_STRING, NPY_UNICODE
math-hiyoko20ccefe
unique for NPY_STRING and NPY_UNICODE
math-hiyoko38626b9
fix construct array
math-hiyoko56bd858
remove unneccessary include
math-hiyokof79736a
refactor
math-hiyokoc4e5438
refactoring
math-hiyoko7c51049
comment
math-hiyokobd70552
feature: unique for NPY_VSTRING
math-hiyokocc8ece6
refactoring
math-hiyokof7b20a0
remove unneccessary include
math-hiyokod0170ed
add test
math-hiyokodbb140f
add error message
math-hiyoko49ed502
linter
math-hiyoko0238cee
linter
math-hiyoko6905978
reserve bucket
math-hiyoko2fc1378
remove emoji from testcase
math-hiyoko1ad6d6c
fix testcase
math-hiyokob478e15
remove error
math-hiyoko95bc405
fix testcase
math-hiyoko3f1811b
fix testcase name
math-hiyoko99e3662
use basic_string
math-hiyokob99542a
fix testcase
math-hiyoko2589dd7
add ValueError
math-hiyoko3f40cdc
fix testcase
math-hiyoko68d5a7b
fix memory error
math-hiyokod38c3e3
remove multibyte char
math-hiyoko8cf2c63
refactoring
math-hiyoko0165d6a
add multibyte char
math-hiyoko243be6b
refactoring
math-hiyokoa6e5d3c
fix memory error
math-hiyoko78b9dc6
fix GIL
math-hiyoko0464617
fix strlen
math-hiyoko908f495
remove PyArray_GETPTR1
math-hiyoko30d1d1a
refactoring
math-hiyoko36c167c
refactoring
math-hiyoko79d31e4
use optional
math-hiyoko00143f9
refactoring
math-hiyoko1cc09f3
refactoring
math-hiyokob29981d
refactoring
math-hiyoko91c5d42
refactoring
math-hiyokoe9c3aac
fix comment
math-hiyoko8191f5f
linter
math-hiyoko4faf36a
add doc
math-hiyokoc6aaf39
DOC: fix
math-hiyoko1053bcb
DOC: fix format
math-hiyoko1afefbe
MNT: refactoring
math-hiyokob5610b1
MNT: refactoring
math-hiyokoc28a7ce
ENH: Store pointers to strings in the set instead of the strings them…
math-hiyokob17011e
FIX: length in memcmp
math-hiyokoc2d5868
ENH: refactoring
math-hiyoko7d4afe0
DOC: 49sec -> 34sec
math-hiyokoad843b0
Update numpy/lib/_arraysetops_impl.py
math-hiyoko45ec2b3
DOC: Mention that hash-based np.unique returns unsorted strings
math-hiyoko52a982d
Merge branch 'feature/#28364' of github.com:math-hiyoko/numpy into fe…
math-hiyokofff254e
ENH: support medium and long vstrings
math-hiyoko370bd8f
FIX: comment
math-hiyoko49dfcb4
ENH: use RAII wrapper
math-hiyokoc5745bf
FIX: error handling of string packing
math-hiyoko3ba9788
FIX: error handling of string packing
math-hiyoko376ad09
FIX: change default bucket size
math-hiyokoaa0db48
FIX: include
math-hiyoko7a2892f
FIX: cast
math-hiyoko896bcba
ENH: support equal_nan=False
math-hiyokof1c1947
FIX: function equal
math-hiyokof35123a
FIX: check the case if pack_status douesn't return NULL
math-hiyokoe6ea015
FIX: check the case if pack_status douesn't return NULL
math-hiyokoddff98f
FIX: stderr
math-hiyoko2758e27
ENH: METH_VARARGS -> METH_FASTCALL
math-hiyokoa6dc86a
FIX: log
math-hiyoko9a936eb
FIX: release allocator
math-hiyoko1e967ee
FIX: comment
math-hiyoko52c2326
FIX: delete log
math-hiyoko6f18a43
ENH: implemented FNV-1a as hash function
math-hiyoko2a1bd41
bool -> npy_bool
math-hiyoko8b632f2
FIX: cast
math-hiyokoa7bfc08
34sec -> 35.1sec
math-hiyokodd0d8f5
Merge branch 'main' into feature/#28364
math-hiyoko9fc9ce3
fix: lint
math-hiyokoFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
linter
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit0238cee37f1cbcff302a0714cf6345808c84d38c
There are no files selected for viewing
2 changes: 1 addition & 1 deletionnumpy/lib/tests/test_arraysetops.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.