Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
BUG: Respect print options in masked array formatting#28698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
VascoConceicao wants to merge1 commit intonumpy:mainChoose a base branch fromVascoConceicao:bugfix/maskedarray-printoptions
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
BUG: Respect print options in masked array formatting#28698
VascoConceicao wants to merge1 commit intonumpy:mainfromVascoConceicao:bugfix/maskedarray-printoptions
+255 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f5da334
to7353323
Compare43c2dcf
to7faa07e
ComparePreviously, the string representation of masked arrays did not honorglobal print options such as floatmode, precision, and suppress.This led to inconsistencies between the display of masked andunmasked arrays.This update addresses the issue by:– Utilizing np.array2string to format the underlying data, ensuring consistency with global print settings.– Replacing masked elements with the masked_print_option string ('--' by default) while preserving formatting for visible elements.– Maintaining support for legacy formatting options, including truncation with ellipsis (...) when legacy='1.13' is set.(Fixesnumpy#28685)
02c1692
toa97d2da
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the string representation of masked arrays did not honor global print options such as floatmode, precision, and suppress. This led to inconsistencies between the display of masked and unmasked arrays.
This update addresses the issue by:
Maybe a bit overkill :)