Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
BUG: fix deepcopying StringDType arrays#28643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If anyone wants to make a fancy deepcopy traverse slot they can still do that in the future. BTW, there's some discussion about long-term plans to make PyObject an opaque struct, which would make this sort of direct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good (and makes sense).
seberg commentedApr 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, agreed we don't have to solve the deepcopy of a custom dtype here. Thanks.
Interesting, but we do need the size, no? In any-case, there are very few places we do that, and this isn't one of them. This just uses |
a342bf3
intonumpy:mainUh oh!
There was an error while loading.Please reload this page.
BUG: fix deepcopying StringDType arrays (#28643)
Uh oh!
There was an error while loading.Please reload this page.
Fixes#28609