Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BLD: Update vendor-meson to fix module_feature conflicts arguments bug#28635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:mainfromseiko2plus:update_vendor_meson
Apr 26, 2025

Conversation

seiko2plus
Copy link
Member

Bug detected and fixed by@Vogtinator in PRnumpy/meson#12. The issue was located in the Meson features module, and implementing the fix will require updating the vendored Meson repository.

@github-actionsgithub-actionsbot added the 36 - BuildBuild related PR labelApr 3, 2025
@seiko2plus
Copy link
MemberAuthor

Fixed the build but I got segfault, maybe its qemu bug. re-test it after brings native armhf support via#28653

@charris
Copy link
Member

@rgommers Is the meson update OK?

@rgommers
Copy link
Member

@rgommers Is the meson update OK?

Yes that's on purpose here. Once CI is green here,numpy/meson#12 can be merged and this PR updated to include themain-numpymeson branch ofhttps://github.com/numpy/meson

@charris
Copy link
Member

The failure looks meson related. Caching? Or maybe the submodule needs an update.

    raise RuntimeError(        "Meson configuration failed; please try `spin build` again with the `--clean` flag."    )

@seiko2plus
Copy link
MemberAuthor

seiko2plus commentedApr 6, 2025•
edited
Loading

The failure looks meson related. Caching? Or maybe the submodule needs an update.

That's true, the submodule (the pr hash) needs a rebasesince it's known blas issue this has been fixed in later meson versions, but it can be ignored for now. What matters is the armhf error needs to be green as Ralf explained.

current armhf error:numpy/_core/tests/test_memmap.py . [ 0%]numpy/_core/tests/test_multiarray.py ................................... [ 0%]....................................................s................... [ 0%]............................................XX.......................... [ 0%].Fatal Python error: Aborted

Current thread 0x41007020 (most recent call first):
File "/numpy/build-install/usr/lib/python3/dist-packages/numpy/_core/fromnumeric.py", line 1122 in sort
File "/numpy/build-install/usr/lib/python3/dist-packages/numpy/_core/tests/test_multiarray.py", line 2094 in test_sort
File "/usr/local/lib/python3.10/dist-packages/_pytest/python.py", line 159 in pytest_pyfunc_call
File "/usr/local/lib/python3.10/dist-packages/pluggy/_callers.py", line 103 in _multicall
File "/usr/local/lib/python3.10/dist-packages/pluggy/_manager.py", line 120 in _hookexec
File "/usr/local/lib/python3.10/dist-packages/pluggy/_hooks.py", line 513 incall
File "/usr/local/lib/python3.10/dist-packages/_pytest/python.py", line 1627 in runtest
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line 174 in pytest_runtest_call
File "/usr/local/lib/python3.10/dist-packages/pluggy/_callers.py", line 103 in _multicall
File "/usr/local/lib/python3.10/dist-packages/pluggy/_manager.py", line 120 in _hookexec
File "/usr/local/lib/python3.10/dist-packages/pluggy/_hooks.py", line 513 incall
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line 242 in
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line 341 in from_call
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line 241 in call_and_report
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line132 in runtestprotocol
File "/usr/local/lib/python3.10/dist-packages/_pytest/runner.py", line 113 in pytest_runtest_protocol
File "/usr/local/lib/python3.10/dist-packages/pluggy/_callers.py", line 103 in _multicall
File "/usr/local/lib/python3.10/dist-packages/pluggy/_manager.py", line 120 in _hookexec
File "/usr/local/lib/python3.10/dist-packages/pluggy/_hooks.py", line 513 incall
File "/usr/local/lib/python3.10/dist-packages/_pytest/main.py", line 362 in pytest_runtestloop
File "/usr/local/lib/python3.10/dist-packages/pluggy/_callers.py", line 103 in _multicall
File "/usr/local/lib/python3.10/dist-packages/pluggy/_manager.py", line 120 in _hookexec
File "/usr/local/lib/python3.10/dist-packages/pluggy/_hooks.py", line 513 incall
File "/usr/local/lib/python3.10/dist-packages/_pytest/main.py", line 337 in _main
File "/usr/local/lib/python3.10/dist-packages/_pytest/main.py", line 283 in wrap_session
File "/usr/local/lib/python3.10/dist-packages/_pytest/main.py", line 330 in pytest_cmdline_main
File "/usr/local/lib/python3.10/dist-packages/pluggy/_callers.py", line 103 in _multicall
File "/usr/local/lib/python3.10/dist-packages/pluggy/_manager.py", line 120 in _hookexec
File "/usr/local/lib/python3.10/dist-packages/pluggy/_hooks.py", line 513 incall
File "/usr/local/lib/python3.10/dist-packages/_pytest/config/init.py", line 175 in main
File "/usr/local/lib/python3.10/dist-packages/_pytest/config/init.py", line 201 in console_main
File "/usr/local/bin/pytest", line 8 in

Extension modules: numpy._core._multiarray_umath, numpy.linalg._umath_linalg, numpy._core._multiarray_tests, numpy._core._rational_tests, numpy._core._umath_tests, cython.cimports.libc.math, numpy.random._common, numpy.random.bit_generator, numpy.random._bounded_integers, numpy.random._mt19937, numpy.random.mtrand, numpy.random._philox, numpy.random._pcg64, numpy.random._sfc64, numpy.random._generator, numpy._core._struct_ufunc_tests, numpy._core._simd, numpy._core._operand_flag_tests, numpy.linalg.lapack_lite (total: 19)

close/open, re-test we have native armhf support now.

@seiko2plus
Copy link
MemberAuthor

@rgommers, I moved link error fix into a separated pull-request#28671

rgommers reacted with thumbs up emoji

Fix incorrect handling of the compiler arguments 'conflicts' thatwas causing failures when detecting asmid instructions at compile time onaarch32 platforms.
@seiko2plusseiko2plus marked this pull request as ready for reviewApril 26, 2025 17:12
@seiko2plusseiko2plus changed the titleBLD: Fix ASIMD feature build on AArch32Update vendor-meson to fix module_feature conflicts arguments bugApr 26, 2025
@seiko2plusseiko2plus added the 09 - Backport-CandidatePRs tagged should be backported labelApr 26, 2025
@charrischarris changed the titleUpdate vendor-meson to fix module_feature conflicts arguments bugBLD: Update vendor-meson to fix module_feature conflicts arguments bugApr 26, 2025
@charrischarris merged commit94b232f intonumpy:mainApr 26, 2025
73 checks passed
@charris
Copy link
Member

Thanks Sayed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
36 - BuildBuild related PR
Projects
None yet
Milestone
2.3.0 release
Development

Successfully merging this pull request may close these issues.

4 participants
@seiko2plus@charris@rgommers@seberg
[8]ページ先頭
©2009-2025 Movatter.jp