Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: Fix crackfortran parsing error when a division occurs within a common block#28633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfromcharris:backport-28396
Apr 2, 2025

Conversation

charris
Copy link
Member

Backport of#28396.

Theanalyzeline function currently passes over all/ characters, presumably assuming they only indicate the name of the common block. However, this means division operations after the common block name are also passed over.
For instance
common /mortmp/ ctmp((lub*(lub+1)*(lub+1))/lpmin+1)
fails to parse correctly.

This pull request attempts to rectify this by counting the number of slashes encountered in the line and only passing over the first two.

  • BUG: Fix crackpython parsing error when a division occurs within a common block

  • Add test for more complicated array sizing expression

  • fix typos

  • Simplify tests to currently supported syntax

  • Use regular expression to find common block name

  • Revert from broken regular expression version to prior version, add comment

  • Add space before inline comment

  • Use regular expression to split line

  • Add missing white space to appease linter

  • More linting fixes

  • Pass maxsplit as a keyword argument

…ommon block (numpy#28396)* BUG: Fix crackpython parsing error when a division occurs within a common block* Add test for more complicated array sizing expression* fix typos* Simplify tests to currently supported syntax* Use regular expression to find common block name* Revert from broken regular expression version to prior version, add comment* Add space before inline comment* Use regular expression to split line* Add missing white space to appease linter* More linting fixes* Pass maxsplit as a keyword argument
@charrischarris added this to the2.2.5 release milestoneApr 2, 2025
@charrischarris merged commit9470412 intonumpy:maintenance/2.2.xApr 2, 2025
70 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
2.2.5 release
Development

Successfully merging this pull request may close these issues.

2 participants
@charris@nchristensen

[8]ページ先頭

©2009-2025 Movatter.jp