NotificationsYou must be signed in to change notification settings
Fork11.8k
Star30.9k

BUG: safer bincount casting (backport to 2.2.x)#28420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

charris merged 1 commit intonumpy:maintenance/2.2.xfromjakirkham:backport_treddy_issue_28354_2.2.x

Mar 3, 2025

Merged

BUG: safer bincount casting (backport to 2.2.x)#28420

charris merged 1 commit intonumpy:maintenance/2.2.xfromjakirkham:backport_treddy_issue_28354_2.2.x

Mar 3, 2025

Conversation

Copy link

Contributor

jakirkham commentedMar 3, 2025

Backport of PR (#28355 ) to2.2.x

cc@tylerjereddy @seberg @charris

BUG: safer bincount casting (numpy#28355)

1efec00

* BUG: safer bincount casting*Fixesnumpy#28354* Force usage of `npy_intp` type in `np.bincount()` and avoidunsafe casting errors with i.e., `npy_uint64`. This is similarto our behavior with indexing.* MAINT, BUG: PR 28355 revisions* `arr_bincount()` now only uses unsafe casting for integerinput types, and the number of casting operations hasbeen reduced for the code path used in above PR.* a test for non-crashing behavior with non-contiguous`bincount()` input has been added.* MAINT, BUG: PR 28355 revisions* Based on reviewer feedback, narrow the scope of the `flags`variable in `arr_bincount()`.* Based on reviewer feedback, add an array-like test for the `uint64`casting issue, which indeed fails before and passes after addinga similar shim to the array-like code path in `arr_bincount()`.* Based on reviewer feedback, switch the patching from `PyArray_Size`to `PyArray_Check` in a few places.* Update numpy/_core/src/multiarray/compiled_base.c---------Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>