Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: Make np.nonzero threading safe#28385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 14 commits intonumpy:maintenance/2.2.xfromcharris:backport-28361
Feb 23, 2025

Conversation

charris
Copy link
Member

Backport#28361.

We add a test for np.nonzero under multi-threading and make np.nonzero safe under the cpython free-threading build. We want to ensure concurrent invocations of the method on the same array do not corrupt the system. Correct results are not guaranteed:

  • If the underlying data is changing, the non-zero indices are not well-defined
  • If the underlying data is changing, we can get indices outside the size of the array due to a part of the return array not being initialized.

Also see#27519. An alternative approach would be to use locks to make the array read-only during the operation.

@charrischarris added 00 - Bug 08 - BackportUsed to tag backport PRs 39 - free-threadingPRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) labelsFeb 23, 2025
@charrischarris added this to the2.2.4 release milestoneFeb 23, 2025
@charrischarris merged commitfc594d4 intonumpy:maintenance/2.2.xFeb 23, 2025
67 of 70 checks passed
@charrischarris deleted the backport-28361 branchFebruary 23, 2025 18:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug08 - BackportUsed to tag backport PRs39 - free-threadingPRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703)
Projects
None yet
Milestone
2.2.4 release
Development

Successfully merging this pull request may close these issues.

3 participants
@charris@eendebakpt@ngoldbaum

[8]ページ先頭

©2009-2025 Movatter.jp