Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MAINT: Update FreeBSD version and fix test failure#28377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

charris
Copy link
Member

Backports of#28328 and#28358.

#28328

Change Freebsd image as perhttps://cirrus-ci.org/guide/FreeBSD/

image

#28358

Since these go via Python (in some form) and Python doesn't use FPEs we can be sure that we don't need to check for FPEs.

Note that while it hidesalmost always spurious FPEs seen on some platforms, there could be certain chains or multiple cast situations where FPEs are checked for other reasons and the spurious FPE will show up.

So it "somewhat":

Closesgh-28351

…umpy#28358)* MAINT: No need to check for check for FPEs in casts to/from objectSince these go via Python (in some form) and Python doesn't use FPEswe can be sure that we don't need to check for FPEs.Note that while it hides *almost always* spurious FPEs seen on someplatforms, there could be certain chains or multiple cast situationswhere FPEs are checked for other reasons and the spurious FPE willshow up.So it "somewhat":Closesnumpygh-28351* MAINT: Follow-up, got the wrong place (the other is OK).* DOC: Add a small comment as per review requestI don't think it needs a comment that we can do this, but maybe itis nice to say that there was a reason for it.
@charrischarris added this to the2.2.4 release milestoneFeb 21, 2025
@charrischarris merged commit10858fe intonumpy:maintenance/2.2.xFeb 21, 2025
70 checks passed
@charrischarris deleted the backport-28328-28358 branchFebruary 21, 2025 17:31
@charrischarris added the 08 - BackportUsed to tag backport PRs labelFeb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance08 - BackportUsed to tag backport PRs
Projects
None yet
Milestone
2.2.4 release
Development

Successfully merging this pull request may close these issues.

3 participants
@charris@abhishek-iitmadras@seberg

[8]ページ先頭

©2009-2025 Movatter.jp