Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
MAINT: Update FreeBSD version and fix test failure#28377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…umpy#28358)* MAINT: No need to check for check for FPEs in casts to/from objectSince these go via Python (in some form) and Python doesn't use FPEswe can be sure that we don't need to check for FPEs.Note that while it hides *almost always* spurious FPEs seen on someplatforms, there could be certain chains or multiple cast situationswhere FPEs are checked for other reasons and the spurious FPE willshow up.So it "somewhat":Closesnumpygh-28351* MAINT: Follow-up, got the wrong place (the other is OK).* DOC: Add a small comment as per review requestI don't think it needs a comment that we can do this, but maybe itis nice to say that there was a reason for it.
10858fe
intonumpy:maintenance/2.2.x 70 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of#28328 and#28358.
#28328
Change Freebsd image as perhttps://cirrus-ci.org/guide/FreeBSD/
#28358
Since these go via Python (in some form) and Python doesn't use FPEs we can be sure that we don't need to check for FPEs.
Note that while it hidesalmost always spurious FPEs seen on some platforms, there could be certain chains or multiple cast situations where FPEs are checked for other reasons and the spurious FPE will show up.
So it "somewhat":
Closesgh-28351