Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TYP: fix positional- and keyword-only params inastype,cross andlinalg#28327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jorenham merged 2 commits intonumpy:mainfromAndrej730:fix_typing_arguments
Feb 15, 2025
Merged

TYP: fix positional- and keyword-only params inastype,cross andlinalg#28327

jorenham merged 2 commits intonumpy:mainfromAndrej730:fix_typing_arguments
Feb 15, 2025

Conversation

@Andrej730
Copy link
Contributor

Example:

importnumpyasnplst=np.eye(3)# No typing issues but on runtime:# TypeError: astype() got some positional-only arguments passed as keyword arguments: 'x, dtype'np.astype(x=lst,dtype=np.float64)

@Andrej730
Copy link
ContributorAuthor

@jorenham Sorry, not sure who to ping - can you please take a look?

@github-actions

This comment has been minimized.

@Andrej730Andrej730 changed the titleFix missing argument flags in typingTYP: fix missing argument flags in typingFeb 13, 2025
@jorenhamjorenham changed the titleTYP: fix missing argument flags in typingTYP: fix positional- and keyword-only parameters inastype andlinalgFeb 13, 2025
@jorenham
Copy link
Member

Looks good! Could you squash your commits and prependTYP: to the message(s)?

@charrischarris added 41 - Static typing 09 - Backport-CandidatePRs tagged should be backported labelsFeb 13, 2025
@jorenhamjorenham self-requested a reviewFebruary 14, 2025 20:51
@jorenhamjorenham changed the titleTYP: fix positional- and keyword-only parameters inastype andlinalgTYP: fix positional- and keyword-only params inastype,cross andlinalgFeb 15, 2025
@jorenhamjorenham merged commite20317a intonumpy:mainFeb 15, 2025
69 of 70 checks passed
@jorenham
Copy link
Member

Thanks Andrej!

Andrej730 reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tylerjereddytylerjereddytylerjereddy left review comments

@jorenhamjorenhamjorenham approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Andrej730@jorenham@tylerjereddy@charris
[8]ページ先頭
©2009-2025 Movatter.jp