Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BUG: fix use-after-free error in npy_hashtable.cpp#27955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
seberg merged 1 commit intonumpy:mainfromngoldbaum:hashtable-use-after-free
Dec 9, 2024

Conversation

ngoldbaum
Copy link
Member

Fixes#27953.

ThosePy_GIL_DISABLED ifdefs clearly confused me.

@ngoldbaumngoldbaum added 39 - free-threadingPRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) 09 - Backport-CandidatePRs tagged should be backported labelsDec 9, 2024
@ngoldbaumngoldbaum added this to the2.2.1 release milestoneDec 9, 2024
@ngoldbaum
Copy link
MemberAuthor

This fixes a universal segfault (on some platforms, others don't notice) on the free-threaded build on 2.2.0, so it would be nice to get an emergency 2.2.1 out with this applied. ping@charris sorry for the hassle!

@sebergseberg merged commitd5a080d intonumpy:mainDec 9, 2024
67 checks passed
@seberg
Copy link
Member

2.2.1 will happen pretty soon anyway, is it important enough to push out something before other fixes come in? (assuming they do)

@ngoldbaum
Copy link
MemberAuthor

I'm not sure how annoying it is. We'll see if more reports come in on non-debug builds.

@seberg
Copy link
Member

I suppose sklearn, etc. might also have CI with this, let's see.

charris pushed a commit to charris/numpy that referenced this pull requestDec 9, 2024
@charrischarris removed the 09 - Backport-CandidatePRs tagged should be backported labelDec 9, 2024
charris added a commit that referenced this pull requestDec 10, 2024
BUG: fix use-after-free error in npy_hashtable.cpp (#27955)
mroeschke added a commit to mroeschke/pandas that referenced this pull requestDec 16, 2024
@mroeschke
Copy link
Contributor

In pandas we're also experiencing segfaults in our free threading, numpy 2.2 CI test build e.g.https://github.com/pandas-dev/pandas/actions/runs/12325213660/job/34404155884?pr=60562. The tests that were failing were callingnumpy.vectorize andnumpy.frompyfunc

I tried running the same build with the numpy nightly and it's passing nowpandas-dev/pandas#60582, so I assume that this PR fixed our issues

mroeschke added a commit to pandas-dev/pandas that referenced this pull requestDec 16, 2024
…0 segfaults (#60582)* Check ifnumpy/numpy#27955 fixes free-threading build* Add comments
KevsterAmp pushed a commit to KevsterAmp/pandas that referenced this pull requestMar 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug39 - free-threadingPRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703)
Projects
None yet
Milestone
2.2.1 release
Development

Successfully merging this pull request may close these issues.

BUG: Python (debug mode+free threading) segfaults at exit since Numpy 2.2.0
4 participants
@ngoldbaum@seberg@mroeschke@charris
[8]ページ先頭
©2009-2025 Movatter.jp