@fengluoqiuwu two things here:

1. It would be nice to explain where theTypeError comes from. As a reviewer if I accept that catching theTypeError may be the best thing (probably alsoOverflowError?) the next thing will be to ask whether this is the right point.
2. We really can't merge even an obvious bug fix without a test and a test is also very helpful for reviewers.

It would be nice to explain where theTypeError comes from.

TheTypeError is raised by the_check_fill_value method, which is converted various errors we want to catch, such asOverflowError, intoTypeError.

We really can't merge even an obvious bug fix without a test and a test is also very helpful for reviewers.

I will add it later.

Thanks! Looking a bit closer, I suspect this is right and we could probably just do it. We don't know that the dtype matches, and we have to just fall back to the default when the "inherited" fill-value fails (this is part of__array_finalize__).

The reason I ask about where it comes from is that it may better to handle this in_check_fill_value itself. I see a similar branch in one place incompare where it catches(TypeError, ValueError).

In this case, I actually like if we could audit/clean up things a bit more. That probably means pushing this logic into_check_fill_value but adding afallback=False argument to it.
(From which I hope two things. First, make it more obvious why the try/except is there. And second, make sure we add this logic in all places where it should be used and not just the one where it happened to be noticed.)

I think in most places probably we should fall back toNone. But when a user doesarr.fill_value = fill_value, I don't think we should (it is the users job to pass a reasonable fill value).

(It is unfortunate, that this was always weird, but the integer casting is now floating up these issues...)

I think in most places probably we should fall back toNone.

I think using the default value is better. In the comment for_check_fill_value, it says that it will only return anndarray, so the return value won’t be checked before use. Additionally, in_comparison, it uses the default value, which is the same situation as this one.