Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10.9k
BUG: Fix user dtype can-cast with python scalar during promotion#27543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The can-cast code for "Python scalars" was old and did not correctlytake into account possible user-dtypes with respect to NEP 50 weakpromotion.To do this, we already had the necessary helper functions that govia promotion (although it took me some brooding to remember ;)).So the fix is rather simple. Actually adding CI/test for the fixis unfortunately hard as it requires such a user DType.
131c3b5 intonumpy:maintenance/2.1.x 65 checks passed
Uh oh!
There was an error while loading.Please reload this page.
jakevdp added a commit to jakevdp/ml_dtypes that referenced this pull requestOct 28, 2024
NumPy changed weak promotion semantics innumpy/numpy#27543,and this caused some of our tests to fail for types that cannot represent zero.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of#27534.
The can-cast code for "Python scalars" was old and did not correctly take into account possible user-dtypes with respect to NEP 50 weak promotion.
To do this, we already had the necessary helper functions that go via promotion (although it took me some brooding to remember ;)).
So the fix is rather simple. Actually adding CI/test for the fix is unfortunately hard as it requires such a user DType.