Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
API: Make any and all return booleans by default#25712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mattip commentedJan 31, 2024
This probably needs some changes in the doc string if not some mention somewhere in the user documentation. It is somewhat niche but a large change in UX |
seberg commentedJan 31, 2024
The any/all docs already claim to always return booleans. We could add a |
seberg commentedJan 31, 2024
That seems very reasonable to me on second thought, so I did that. |
mattip commentedJan 31, 2024
Bleh. I think doc building is failing because of some partial merge with main, and the requirements file moved in#25697. |
mattip left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, once CI is happy.
seberg commentedJan 31, 2024
Hmmm, will try to close/reopen, circleci choked on something. |
seberg commentedJan 31, 2024
Sorry, I missed your comment jumping to the end, will try rebasing then... |
The method supports a `dtype=` argument, but I am thinking topromote `np.logical_or.reduce()` instead.
seberg commentedJan 31, 2024
OK, CI happy now, thanks for the review Matti. |
The method supports a
dtype=argument, but I am thinking to promotenp.logical_or.reduce()instead.Closesgh-4352