Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
DEP: Expireset_numeric_ops and the corresponding C functions deprecation#23998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…cationThis simply expires the deprecations because I saw they were one causeof doctest failures in the other PR, but its good anyway.
Unlike the set version, we don't use it internally.
mhvk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Clean-up is nice! But it looks like one should be able to get rid ofnumber.c andnumber.h altogether! (moving some code toumathmodule)
Uh oh!
There was an error while loading.Please reload this page.
mhvk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With that conversation resolved, I think this is all good to go!
This simply expires the deprecations because I saw they were one cause of doctest failures in the other PR, but its good anyway.