Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ENH: Pass optimizations arguments to asv build#17284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
charris merged 1 commit intonumpy:masterfromseiko2plus:pass_opt2asv_run
Oct 10, 2020

Conversation

@seiko2plus
Copy link
Member

@seiko2plusseiko2plus commentedSep 10, 2020
edited
Loading

ENH: Pass optimizations arguments to asv build#17284

This patch allows passing-j,--cpu-baseline,--cpu-dispatch and--disable-optimization
to ASV build when argument--bench-compare is used.

TODO:

  • local test

@seiko2plus
Copy link
MemberAuthor

@seberg, I just don't understand why ASV doesn't provide a direct way to specify custom build options? Am I missing something?

@seberg
Copy link
Member

I looked around a bit, and don't see a way other than as part of the config. However, we could use--config to use a custom config file rather than deleting the current config? May want to ping Pauli, though, at least if that doesn't see right.

@Qiyu8
Copy link
Member

I think this is a good solution to benchmark flexible universal intrinsic usage. but asv community still needs to considering the necessity of adding{build_args} toasv.config.json.@pv what do you think?

@seiko2plusseiko2plusforce-pushed thepass_opt2asv_run branch 4 times, most recently from4fcf2bb to6edbba2CompareSeptember 11, 2020 13:31
@seiko2plus
Copy link
MemberAuthor

seiko2plus commentedSep 11, 2020
edited
Loading

@seberg,

I looked around a bit, and don't see a way other than as part of the config.

I confirm it, thank you!

we could use --config to use a custom config file rather than deleting the current config?

I followed your suggestion, I kept the main config file as-is so it can be used withASV command.

@Qiyu8,

I think this is a good solution to benchmark flexible universal intrinsic usage.

An effective workaround but we still have other obstacles such as providing auto-generated test data and
provides the ability to check the sanity of it, similar to whatOpenCV do, another nightmare I guess.
It would be easier for me to dropASV and create our own benchmark tool, but I guess the community wouldn't easily
accept such a move like that.

@seberg
Copy link
Member

Maybe its right and we should consider upstreaming things to ASV. I am a bit worried that running plain ASV won't have access to this, but there may not be a good way to do that.
Does this give the baseline/optimized/disabled versions different environment names in the ASV run?

@seiko2plus
Copy link
MemberAuthor

seiko2plus commentedSep 11, 2020
edited
Loading

@seberg,

Does this give the baseline/optimized/disabled versions different environment names in the ASV run?

No, it generates a config file with the required build options then pass it through
--config, it also clearswhole cache the involved commits cache if the user changed the build options.

@seiko2plus
Copy link
MemberAuthor

seiko2plus commentedSep 11, 2020
edited
Loading

@seberg,

I am a bit worried that running plain ASV won't have access to this, but there may not be a good way to do that.

I didn't touch the original config file, I created a new asv config insteadasv_compare.conf.json and it only works through--bench-compare.

  This patch allows passing `-j`, `--cpu-baseline`, `--cpu-dispatch` and `--disable-optimization`  to ASV build when argument `--bench-compare` is used.
Copy link
MemberAuthor

@seiko2plusseiko2plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, what do you think@pv?

@charris
Copy link
Member

This needs documentation so people will know how to use it. Maybe in theREADME.rst orruntests.py files?

caffeinatedgaze reacted with eyes emoji

@charrischarris merged commit07a54df intonumpy:masterOct 10, 2020
@charris
Copy link
Member

Thanks Sayed. I put this in to aid the ongoing SIMD work, but more usage documentation would be helpful.

seiko2plus reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seiko2plus@seberg@Qiyu8@charris

[8]ページ先頭

©2009-2025 Movatter.jp