Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
ENH: Pass optimizations arguments to asv build#17284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
seiko2plus commentedSep 10, 2020
@seberg, I just don't understand why ASV doesn't provide a direct way to specify custom build options? Am I missing something? |
seberg commentedSep 10, 2020
I looked around a bit, and don't see a way other than as part of the config. However, we could use |
Qiyu8 commentedSep 11, 2020
I think this is a good solution to benchmark flexible universal intrinsic usage. but asv community still needs to considering the necessity of adding |
4fcf2bb to6edbba2Compareseiko2plus commentedSep 11, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I confirm it, thank you!
I followed your suggestion, I kept the main config file as-is so it can be used with
An effective workaround but we still have other obstacles such as providing auto-generated test data and |
Uh oh!
There was an error while loading.Please reload this page.
seberg commentedSep 11, 2020
Maybe its right and we should consider upstreaming things to ASV. I am a bit worried that running plain ASV won't have access to this, but there may not be a good way to do that. |
seiko2plus commentedSep 11, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No, it generates a config file with the required build options then pass it through |
Uh oh!
There was an error while loading.Please reload this page.
seiko2plus commentedSep 11, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I didn't touch the original config file, I created a new asv config instead |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This patch allows passing `-j`, `--cpu-baseline`, `--cpu-dispatch` and `--disable-optimization` to ASV build when argument `--bench-compare` is used.
9504077 to96be695Compare
seiko2plus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, what do you think@pv?
charris commentedSep 27, 2020
This needs documentation so people will know how to use it. Maybe in the |
charris commentedOct 10, 2020
Thanks Sayed. I put this in to aid the ongoing SIMD work, but more usage documentation would be helpful. |
Uh oh!
There was an error while loading.Please reload this page.
ENH: Pass optimizations arguments to asv build#17284
This patch allows passing
-j,--cpu-baseline,--cpu-dispatchand--disable-optimizationto ASV build when argument
--bench-compareis used.TODO: