Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ENH: Provides a deep benchmark for universal functions#15992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
seiko2plus wants to merge1 commit intonumpy:main
base:main
Choose a base branch
Loading
fromseiko2plus:asv_deep_bench

Conversation

seiko2plus
Copy link
Member

@seiko2plusseiko2plus commentedApr 15, 2020
edited
Loading

Provides a deep benchmark for universal functions.

This an alternative benchmark for#15987 based onASV.

@mattip
Copy link
Member

It seems the log output is now too large for travis, it exceeds 50,000 lines. Is there a way to tweak the benchmark run to be less verbose?

@seiko2plus
Copy link
MemberAuthor

@mattip, I guess the only way is by providing argument options to control of generated tests, same as in#15987, example--strides,--sizes(array sizes),--nsamples(number of collected samples), and different filter mechanism beyond ASV that allow us to disable deep tests by default unless user provided a regex that hit some matches. I think it can be handle it throughruntests.py. what do u think?

@mattip
Copy link
Member

It seems quite complicated. How will anyone track the changes over time when the full suite takes so long to run? What is the goal of the added benchmarks: perhaps there is another way to achieve the same goal.

@seiko2plus
Copy link
MemberAuthor

@mattip,

What is the goal of the added benchmarks

I was simply want to detect the performance changes, so I can reply to@rgommerscomment. also for the upcoming patches.

How will anyone track the changes?

simply you don't need to run all the tests only filter what u target through the regex.

full suite takes so long to run?

ASV kinda slow even with disabling ASV's warmup process

perhaps there is another way to achieve the same goal.

This patch#15987 is more effective and faster. currently, I'm doing some final tests on it and
it seems I'm going to rely on it instead of using ASV.

@mattip
Copy link
Member

it seems I'm going to rely on it instead of using ASV.

Are you sure you cannot do what you wish with ASV and using your C code fromgh-15987 (although that code looks fragile: what happens if we add more ufuncs)?

@seiko2plus
Copy link
MemberAuthor

@mattip,

Are you sure you cannot do what you wish with ASV and using your C code fromgh-15987

There's no way to integrate the C code fromgh-15987 since ASV doesn't provide a method to specify the elapsed time of each sample.

(although that code looks fragile

The python code still needs more improvements, but the C code looks good to me.

what happens if we add more ufuncs)?

The python script collects all ufuncs viadir() and fetches the input types from ufunc's attributetypes same as what this patch does. so the code is frinedly with any new ufuncs.

@mattip
Copy link
Member

I still prefer this as an alternative togh-15987.@seiko2plus do you now see a way to make the output nicer/less verbose?

@seiko2plusseiko2plus marked this pull request as draftJuly 14, 2020 06:27
@seiko2plus
Copy link
MemberAuthor

@mattip, yes, I see away. I'm going to count ongh-15987 for now, then I will work on it after getting done from my other pull-requests.

@mattipmattip added the component: SIMDIssues in SIMD (fast instruction sets) code or machinery labelJul 21, 2020
Base automatically changed frommaster tomainMarch 4, 2021 02:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement28 - Benchmarkcomponent: SIMDIssues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@seiko2plus@mattip@rgommers

[8]ページ先頭

©2009-2025 Movatter.jp